From a8b283a5096c6dc47bc0100d7478d98e80d9c58a Mon Sep 17 00:00:00 2001
From: Jialecl <jialestrabajos@gmail.com>
Date: Tue, 14 Jan 2025 15:09:36 +0100
Subject: [PATCH 1/2] ariaLabel prop added to select component

---
 .../screens/components/select/code/SelectCodePage.tsx  | 10 ++++++++++
 packages/lib/src/select/Select.test.tsx                |  9 +++++++++
 packages/lib/src/select/Select.tsx                     |  2 ++
 packages/lib/src/select/types.ts                       |  4 ++++
 4 files changed, 25 insertions(+)

diff --git a/apps/website/screens/components/select/code/SelectCodePage.tsx b/apps/website/screens/components/select/code/SelectCodePage.tsx
index 22361c7f1c..82a072f417 100644
--- a/apps/website/screens/components/select/code/SelectCodePage.tsx
+++ b/apps/website/screens/components/select/code/SelectCodePage.tsx
@@ -268,6 +268,16 @@ const sections = [
             <td>Reference to the component.</td>
             <td>-</td>
           </tr>
+          <tr>
+            <td>ariaLabel</td>
+            <td>
+              <TableCode>string</TableCode>
+            </td>
+            <td>
+              Specifies a string to be used as the name for the select element when no <Code>label</Code> is provided.
+            </td>
+            <td>'Select input'</td>
+          </tr>
         </tbody>
       </DxcTable>
     ),
diff --git a/packages/lib/src/select/Select.test.tsx b/packages/lib/src/select/Select.test.tsx
index 6ac3256158..2da6718b04 100644
--- a/packages/lib/src/select/Select.test.tsx
+++ b/packages/lib/src/select/Select.test.tsx
@@ -114,12 +114,21 @@ describe("Select component tests", () => {
     expect(select.getAttribute("aria-labelledby")).toBe(label.id);
     expect(select.getAttribute("aria-activedescendant")).toBeNull();
     expect(select.getAttribute("aria-invalid")).toBe("false");
+    expect(select.getAttribute("aria-label")).toBeNull();
     await userEvent.click(select);
     const list = getByRole("listbox");
     expect(select.getAttribute("aria-controls")).toBe(list.id);
     expect(list.getAttribute("aria-multiselectable")).toBe("false");
   });
 
+  test("Renders with correct error aria label", () => {
+    const { getByRole } = render(
+      <DxcSelect ariaLabel="Example aria label" placeholder="Example" options={singleOptions} />
+    );
+    const select = getByRole("combobox");
+    expect(select.getAttribute("aria-label")).toBe("Example aria label");
+  });
+
   test("Single selection: Renders with correct default value", async () => {
     const { getByText, getByRole, getAllByRole, queryByRole, container } = render(
       <DxcSelect label="test-select-label" name="test" defaultValue="4" options={singleOptions} />
diff --git a/packages/lib/src/select/Select.tsx b/packages/lib/src/select/Select.tsx
index 334a34d9e9..b6a3ba9fc7 100644
--- a/packages/lib/src/select/Select.tsx
+++ b/packages/lib/src/select/Select.tsx
@@ -52,6 +52,7 @@ const DxcSelect = forwardRef<RefType, SelectPropsType>(
       margin,
       size = "medium",
       tabIndex = 0,
+      ariaLabel = "Select input",
     },
     ref
   ): JSX.Element => {
@@ -327,6 +328,7 @@ const DxcSelect = forwardRef<RefType, SelectPropsType>(
                 aria-invalid={!!error}
                 aria-errormessage={error ? errorId : undefined}
                 aria-required={!disabled && !optional}
+                aria-label={label ? undefined : ariaLabel}
               >
                 {multiple && Array.isArray(selectedOption) && selectedOption.length > 0 && (
                   <SelectionIndicator>
diff --git a/packages/lib/src/select/types.ts b/packages/lib/src/select/types.ts
index d6858b661c..850746167e 100644
--- a/packages/lib/src/select/types.ts
+++ b/packages/lib/src/select/types.ts
@@ -94,6 +94,10 @@ type CommonProps = {
    * Value of the tabindex attribute.
    */
   tabIndex?: number;
+  /**
+   * Specifies a string to be used as the name for the select element when no `label` is provided.
+   */
+  ariaLabel?: string;
 };
 
 type SingleSelect = CommonProps & {

From fa7ef2b69fa5df11071934a419dd17b39ab03270 Mon Sep 17 00:00:00 2001
From: Jialecl <jialestrabajos@gmail.com>
Date: Wed, 15 Jan 2025 11:17:06 +0100
Subject: [PATCH 2/2] removed input from ariaLabel default value

---
 apps/website/screens/components/select/code/SelectCodePage.tsx | 2 +-
 packages/lib/src/select/Select.tsx                             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/website/screens/components/select/code/SelectCodePage.tsx b/apps/website/screens/components/select/code/SelectCodePage.tsx
index 82a072f417..cdeba01db9 100644
--- a/apps/website/screens/components/select/code/SelectCodePage.tsx
+++ b/apps/website/screens/components/select/code/SelectCodePage.tsx
@@ -276,7 +276,7 @@ const sections = [
             <td>
               Specifies a string to be used as the name for the select element when no <Code>label</Code> is provided.
             </td>
-            <td>'Select input'</td>
+            <td>'Select'</td>
           </tr>
         </tbody>
       </DxcTable>
diff --git a/packages/lib/src/select/Select.tsx b/packages/lib/src/select/Select.tsx
index b6a3ba9fc7..b1cc105805 100644
--- a/packages/lib/src/select/Select.tsx
+++ b/packages/lib/src/select/Select.tsx
@@ -52,7 +52,7 @@ const DxcSelect = forwardRef<RefType, SelectPropsType>(
       margin,
       size = "medium",
       tabIndex = 0,
-      ariaLabel = "Select input",
+      ariaLabel = "Select",
     },
     ref
   ): JSX.Element => {