Skip to content

Commit b4dd815

Browse files
Fix latest comments
1 parent 7426be0 commit b4dd815

3 files changed

Lines changed: 29 additions & 24 deletions

File tree

packages/lib/src/footer/Footer.test.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,16 @@ describe("Footer component tests", () => {
135135

136136
describe("getContrastColor function", () => {
137137
test("should return black color for light backgrounds", () => {
138-
expect(getContrastColor("#FFFFFF")).toBe("#000000");
139-
expect(getContrastColor("#F5F5F5")).toBe("#000000");
140-
expect(getContrastColor("rgb(255, 255, 255)")).toBe("#000000");
141-
expect(getContrastColor("rgb(245, 245, 245)")).toBe("#000000");
138+
expect(getContrastColor("#FFFFFF")).toBe("var(--color-fg-neutral-dark)");
139+
expect(getContrastColor("#F5F5F5")).toBe("var(--color-fg-neutral-dark)");
140+
expect(getContrastColor("rgb(255, 255, 255)")).toBe("var(--color-fg-neutral-dark)");
141+
expect(getContrastColor("rgb(245, 245, 245)")).toBe("var(--color-fg-neutral-dark)");
142142
});
143143

144144
test("should return white color for dark backgrounds", () => {
145-
expect(getContrastColor("#000000")).toBe("#FFFFFF");
146-
expect(getContrastColor("#333333")).toBe("#FFFFFF");
147-
expect(getContrastColor("rgb(0, 0, 0)")).toBe("#FFFFFF");
148-
expect(getContrastColor("rgb(51, 51, 51)")).toBe("#FFFFFF");
145+
expect(getContrastColor("#000000")).toBe("var(--color-fg-neutral-bright)");
146+
expect(getContrastColor("#333333")).toBe("var(--color-fg-neutral-bright)");
147+
expect(getContrastColor("rgb(0, 0, 0)")).toBe("var(--color-fg-neutral-bright)");
148+
expect(getContrastColor("rgb(51, 51, 51)")).toBe("var(--color-fg-neutral-bright)");
149149
});
150150
});

packages/lib/src/footer/Footer.tsx

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,17 @@ const RightContainer = styled.div<{ width: number }>`
101101
`;
102102

103103
const SocialAnchor = styled.a`
104-
height: fit-content;
104+
height: var(--dimensions-28);
105+
aspect-ratio: 1 / 1;
105106
border-radius: var(--border-radius-s);
107+
display: flex;
108+
justify-content: center;
109+
align-items: center;
110+
border: 2px solid transparent;
111+
box-sizing: border-box;
106112
107113
&:focus {
108-
outline: var(--border-width-m) var(--border-style-default) var(--border-color-secondary-medium);
109-
outline-offset: var(--border-width-m);
114+
border-color: var(--border-color-secondary-medium);
110115
}
111116
`;
112117

@@ -115,7 +120,7 @@ const SocialIconContainer = styled.div`
115120
align-items: center;
116121
color: var(--color-fg-primary-strong);
117122
overflow: hidden;
118-
font-size: var(--height-s);
123+
font-size: var(--height-xs);
119124
120125
svg {
121126
height: var(--height-xs);
@@ -203,7 +208,7 @@ const Copyright = styled.div<{ width: number }>`
203208
${(props) =>
204209
getResponsiveStyles.isLargeScreen(props.width) &&
205210
css`
206-
grid-column-start: 2;
211+
grid-column-start: 3;
207212
`}
208213
209214
${(props) =>

packages/lib/src/footer/Icons.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,57 +5,57 @@ export const dxcLogo = (
55
<path
66
d="M171.5-54.124v12.539h-3.6V-54.124h-4.973v-3.191h13.54v3.191H171.5"
77
transform="translate(-68.528 65.45)"
8-
fill="var(--color-fg-primary-strong)"
8+
fill="#6f4b97"
99
/>
1010
<path
1111
d="M189.96-41.585V-57.315h12.326v3.079h-8.753v3.191h7.7v3.078h-7.7v3.3h8.87v3.078H189.96"
1212
transform="translate(-77.56 65.45)"
13-
fill="var(--color-fg-primary-strong)"
13+
fill="#6f4b97"
1414
/>
1515
<path
1616
d="M223.558-41.438a8.1,8.1,0,0,1-8.382-8.1v-.045a8.161,8.161,0,0,1,8.522-8.146,8.6,8.6,0,0,1,6.444,2.431l-2.289,2.543a6.133,6.133,0,0,0-4.178-1.778,4.743,4.743,0,0,0-4.738,4.905v.045a4.752,4.752,0,0,0,4.738,4.95,6,6,0,0,0,4.295-1.845l2.288,2.228a8.491,8.491,0,0,1-6.7,2.813"
1717
transform="translate(-86.019 65.583)"
18-
fill="var(--color-fg-primary-strong)"
18+
fill="#6f4b97"
1919
/>
2020
<path
2121
d="M254.988-41.585V-47.9h-6.63v6.315h-3.6V-57.315h3.6v6.225h6.63v-6.225h3.594v15.731h-3.594"
2222
transform="translate(-95.903 65.45)"
23-
fill="var(--color-fg-primary-strong)"
23+
fill="#6f4b97"
2424
/>
2525
<path
2626
d="M285.991-41.585l-7.914-10v10h-3.549V-57.315h3.316l7.657,9.685v-9.685h3.549v15.731h-3.058"
2727
transform="translate(-105.869 65.45)"
28-
fill="var(--color-fg-primary-strong)"
28+
fill="#6f4b97"
2929
/>
3030
<path
3131
d="M317.2-49.583a4.869,4.869,0,0,0-4.949-4.95,4.793,4.793,0,0,0-4.9,4.905v.045a4.869,4.869,0,0,0,4.949,4.95,4.793,4.793,0,0,0,4.9-4.905Zm-4.949,8.145c-5.043,0-8.661-3.623-8.661-8.1v-.045c0-4.478,3.666-8.146,8.708-8.146s8.66,3.623,8.66,8.1v.045c0,4.477-3.664,8.145-8.708,8.145"
3232
transform="translate(-115.631 65.583)"
33-
fill="var(--color-fg-primary-strong)"
33+
fill="#6f4b97"
3434
/>
3535
<path
3636
d="M336.786-41.585V-57.315h3.6v12.584h8.148v3.146H336.786"
3737
transform="translate(-126.654 65.45)"
38-
fill="var(--color-fg-primary-strong)"
38+
fill="#6f4b97"
3939
/>
4040
<path
4141
d="M372.78-49.583a4.87,4.87,0,0,0-4.949-4.95,4.794,4.794,0,0,0-4.9,4.905v.045a4.869,4.869,0,0,0,4.949,4.95,4.794,4.794,0,0,0,4.9-4.905Zm-4.949,8.145c-5.043,0-8.662-3.623-8.662-8.1v-.045c0-4.478,3.666-8.146,8.708-8.146s8.661,3.623,8.661,8.1v.045c0,4.477-3.666,8.145-8.708,8.145"
4242
transform="translate(-135.016 65.583)"
43-
fill="var(--color-fg-primary-strong)"
43+
fill="#6f4b97"
4444
/>
4545
<path
4646
d="M399.735-41.438c-5.09,0-8.592-3.443-8.592-8.1v-.045a8.243,8.243,0,0,1,8.568-8.146,9.18,9.18,0,0,1,6.42,2.16l-2.265,2.634a6.141,6.141,0,0,0-4.272-1.6,4.807,4.807,0,0,0-4.692,4.905v.045a4.8,4.8,0,0,0,4.949,4.995,5.89,5.89,0,0,0,3.384-.945v-2.25h-3.618v-2.992h7.1v6.841a10.837,10.837,0,0,1-6.98,2.5"
4747
transform="translate(-145.284 65.583)"
48-
fill="var(--color-fg-primary-strong)"
48+
fill="#6f4b97"
4949
/>
5050
<path
5151
d="M428.664-47.855v6.27h-3.6v-6.2l-6.28-9.528h4.2L426.89-51l3.968-6.315h4.085l-6.28,9.46"
5252
transform="translate(-154.162 65.45)"
53-
fill="var(--color-fg-primary-strong)"
53+
fill="#6f4b97"
5454
/>
5555
<path
5656
d="M84.218-55.737a10.063,10.063,0,0,1,2.589-4.4,9.792,9.792,0,0,1,6.985-2.77h11.328V-69.3H93.792a17.041,17.041,0,0,0-11.8,4.759,16.344,16.344,0,0,0-3.547,5.115,13.247,13.247,0,0,0-1.122,3.688Zm0,4.877a10.065,10.065,0,0,0,2.589,4.4,9.793,9.793,0,0,0,6.985,2.77h11.328V-37.3H93.792a17.042,17.042,0,0,1-11.8-4.759,16.339,16.339,0,0,1-3.547-5.114,13.251,13.251,0,0,1-1.122-3.688ZM63.1-47.98,54.45-37.3H45.873l12.957-16-12.957-16H54.45L63.1-58.619l8.65-10.68h8.578l-12.957,16,12.957,16H71.749ZM48.875-55.737a13.212,13.212,0,0,0-1.122-3.688,16.359,16.359,0,0,0-3.546-5.115,17.043,17.043,0,0,0-11.8-4.759H21.08v6.393H32.408a9.79,9.79,0,0,1,6.985,2.77,10.072,10.072,0,0,1,2.59,4.4Zm0,4.877a13.215,13.215,0,0,1-1.122,3.688,16.353,16.353,0,0,1-3.546,5.114,17.044,17.044,0,0,1-11.8,4.759H21.08v-6.393H32.408a9.791,9.791,0,0,0,6.985-2.77,10.074,10.074,0,0,0,2.59-4.4h6.892"
5757
transform="translate(-21.08 69.298)"
58-
fill="var(--color-fg-primary-strong)"
58+
fill="#6f4b97"
5959
/>
6060
</g>
6161
</svg>

0 commit comments

Comments
 (0)