Merge pull request #5 from dunglas/fix/linter

fix: golangci-lint errors

Author: dunglas

.golangci.yaml

@@ -4,11 +4,16 @@ run:
 linters:
   enable-all: true
   disable:
+    - gomnd
+    - exhaustivestruct
     - testpackage
     - godox
+    - wrapcheck
 
 issues:
   exclude-rules:
     - path: _test\.go
       linters:
         - funlen
+        - forbidigo
+        - errorlint

bareitem_test.go

@@ -8,6 +8,8 @@ import (
 )
 
 func TestParseBareItem(t *testing.T) {
+	t.Parallel()
+
 	data := []struct {
 		in  string
 		out interface{}
@@ -40,6 +42,8 @@ func TestParseBareItem(t *testing.T) {
 }
 
 func TestMarshalBareItem(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil {
 			t.Errorf("The code did not panic")
@@ -51,6 +55,8 @@ func TestMarshalBareItem(t *testing.T) {
 }
 
 func TestAssertBareItem(t *testing.T) {
+	t.Parallel()
+
 	defer func() {
 		if r := recover(); r == nil {
 			t.Errorf("The code did not panic")

binary_test.go

@@ -7,6 +7,8 @@ import (
 )
 
 func TestBinary(t *testing.T) {
+	t.Parallel()
+
 	var bd strings.Builder
 	_ = marshalBinary(&bd, []byte{4, 2})
 
@@ -16,6 +18,8 @@ func TestBinary(t *testing.T) {
 }
 
 func TestParseBinary(t *testing.T) {
+	t.Parallel()
+
 	data := []struct {
 		in  string
 		out []byte

boolean_test.go

@@ -6,6 +6,8 @@ import (
 )
 
 func TestBooleanMarshalSFV(t *testing.T) {
+	t.Parallel()
+
 	var b strings.Builder
 
 	_ = marshalBoolean(&b, true)
@@ -23,6 +25,8 @@ func TestBooleanMarshalSFV(t *testing.T) {
 }
 
 func TestParseBoolean(t *testing.T) {
+	t.Parallel()
+
 	data := []struct {
 		in  string
 		out bool

decimal.go

@@ -21,9 +21,9 @@ func marshalDecimal(b io.StringWriter, d float64) error {
 	const TH = 0.001
 
 	rounded := math.RoundToEven(d/TH) * TH
-	int, frac := math.Modf(math.RoundToEven(d/TH) * TH)
+	i, frac := math.Modf(math.RoundToEven(d/TH) * TH)
 
-	if int < -999999999999 || int > 999999999999 {
+	if i < -999999999999 || i > 999999999999 {
 		return ErrInvalidDecimal
 	}
 

decimal_test.go

@@ -6,6 +6,8 @@ import (
 )
 
 func TestDecimalMarshalSFV(t *testing.T) {
+	t.Parallel()
+
 	data := []struct {
 		in       float64
 		expected string

decode_test.go

@@ -3,6 +3,8 @@ package httpsfv
 import "testing"
 
 func TestDecodeError(t *testing.T) {
+	t.Parallel()
+
 	_, err := UnmarshalItem([]string{"invalid-é"})
 
 	if err.Error() != "unmarshal error: character 8" {

dictionary_test.go

@@ -7,6 +7,8 @@ import (
 )
 
 func TestDictionnary(t *testing.T) {
+	t.Parallel()
+
 	dict := NewDictionary()
 
 	add := []struct {
@@ -67,8 +69,7 @@ func TestDictionnary(t *testing.T) {
 		t.Errorf(`Get("notexist") = %v, %v; nil, false expected`, v, ok)
 	}
 
-	k := dict.Names()
-	if len(k) != 5 {
+	if k := dict.Names(); len(k) != 5 {
 		t.Errorf(`Names() = %v; {"f_o1o3-", "*f0.o*"} expected`, k)
 	}
 
@@ -85,6 +86,8 @@ func TestDictionnary(t *testing.T) {
 }
 
 func TestUnmarshalDictionary(t *testing.T) {
+	t.Parallel()
+
 	d1 := NewDictionary()
 	d1.Add("a", NewItem(false))
 	d1.Add("b", NewItem(true))

encode_test.go

@@ -3,6 +3,8 @@ package httpsfv
 import "testing"
 
 func TestMarshal(t *testing.T) {
+	t.Parallel()
+
 	i := NewItem(22.1)
 	i.Params.Add("foo", true)
 	i.Params.Add("bar", Token("baz"))
@@ -14,13 +16,14 @@ func TestMarshal(t *testing.T) {
 	tok.Params.Add("a", "b")
 	d.Add("tok", tok)
 
-	res, _ := Marshal(d)
-	if res != `i=22.1;foo;bar=baz, tok=foo;a="b"` {
+	if res, _ := Marshal(d); res != `i=22.1;foo;bar=baz, tok=foo;a="b"` {
 		t.Errorf("marshal: bad result")
 	}
 }
 
 func TestMarshalError(t *testing.T) {
+	t.Parallel()
+
 	if _, err := Marshal(NewItem(Token("à"))); err == nil {
 		t.Errorf("marshal: error expected")
 	}

httpwg_test.go

@@ -135,6 +135,8 @@ func valToDictionary(e interface{}) *Dictionary {
 }
 
 func TestOfficialTestSuiteParsing(t *testing.T) {
+	t.Parallel()
+
 	const dir = "structured-field-tests/"
 	f, _ := os.Open(dir)
 	files, _ := f.Readdir(-1)
@@ -245,6 +247,8 @@ func BenchmarkSerializingOfficialExamples(b *testing.B) {
 }
 
 func TestOfficialTestSuiteSerialization(t *testing.T) {
+	t.Parallel()
+
 	const dir = "structured-field-tests/serialisation-tests/"
 
 	f, _ := os.Open(dir)