Fix non-flat vector with nested VARIANT (1.5)#695
Merged
Conversation
This is a backport of the PR duckdb#694 to `v1.5-variegata` stable branch. It appeared that with nested `VARIANT`/`JSON` a non-flat (constant) vector can be surfaced during conversion of a result set to Java types. This PR fixes that code path flattening the vector before processing. This is more like a band-aid - for long-term the support of `VARIANT` needs to be re-implemented on top of `DuckDBDataChunkReader` (see duckdb#682). Fixes: duckdb#692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of the PR #694 to
v1.5-variegatastable branch.It appeared that with nested
VARIANT/JSONa non-flat (constant) vector can be surfaced during conversion of a result set to Java types.This PR fixes that code path flattening the vector before processing.
This is more like a band-aid - for long-term the support of
VARIANTneeds to be re-implemented on top ofDuckDBDataChunkReader(see #682).Fixes: #692