Skip to content

Commit 09fb9e4

Browse files
duckdblabs-botgithub-actions[bot]
authored andcommitted
Update vendored DuckDB sources to 716e174217
1 parent c705899 commit 09fb9e4

5 files changed

Lines changed: 10 additions & 8 deletions

File tree

src/duckdb/src/function/macro_function.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ MacroBindResult MacroFunction::BindMacroFunction(
4747
InsertionOrderPreservingMap<unique_ptr<ParsedExpression>> &named_arguments, idx_t depth) {
4848

4949
ExpressionBinder expr_binder(binder, binder.context);
50-
50+
expr_binder.lambda_bindings = binder.lambda_bindings;
5151
// Find argument types and separate positional and default arguments
5252
vector<LogicalType> positional_arg_types;
5353
InsertionOrderPreservingMap<LogicalType> named_arg_types;

src/duckdb/src/function/scalar/create_sort_key.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -696,13 +696,15 @@ void PrepareSortData(Vector &result, idx_t size, SortKeyLengthInfo &key_lengths,
696696
}
697697
}
698698

699-
void FinalizeSortData(Vector &result, idx_t size) {
699+
void FinalizeSortData(Vector &result, idx_t size, const SortKeyLengthInfo &key_lengths,
700+
const unsafe_vector<idx_t> &offsets) {
700701
switch (result.GetType().id()) {
701702
case LogicalTypeId::BLOB: {
702703
auto result_data = FlatVector::GetData<string_t>(result);
703704
// call Finalize on the result
704705
for (idx_t r = 0; r < size; r++) {
705-
result_data[r].Finalize();
706+
result_data[r].SetSizeAndFinalize(offsets[r],
707+
key_lengths.variable_lengths[r] + key_lengths.constant_length);
706708
}
707709
break;
708710
}
@@ -739,7 +741,7 @@ void CreateSortKeyInternal(vector<unique_ptr<SortKeyVectorData>> &sort_key_data,
739741
SortKeyConstructInfo info(modifiers[c], offsets, data_pointers.get());
740742
ConstructSortKey(*sort_key_data[c], info);
741743
}
742-
FinalizeSortData(result, row_count);
744+
FinalizeSortData(result, row_count, key_lengths, offsets);
743745
}
744746

745747
} // namespace

src/duckdb/src/function/table/version/pragma_version.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#ifndef DUCKDB_PATCH_VERSION
2-
#define DUCKDB_PATCH_VERSION "2-dev5"
2+
#define DUCKDB_PATCH_VERSION "2-dev21"
33
#endif
44
#ifndef DUCKDB_MINOR_VERSION
55
#define DUCKDB_MINOR_VERSION 4
@@ -8,10 +8,10 @@
88
#define DUCKDB_MAJOR_VERSION 1
99
#endif
1010
#ifndef DUCKDB_VERSION
11-
#define DUCKDB_VERSION "v1.4.2-dev5"
11+
#define DUCKDB_VERSION "v1.4.2-dev21"
1212
#endif
1313
#ifndef DUCKDB_SOURCE_ID
14-
#define DUCKDB_SOURCE_ID "7d019a58cd"
14+
#define DUCKDB_SOURCE_ID "716e174217"
1515
#endif
1616
#include "duckdb/function/table/system_functions.hpp"
1717
#include "duckdb/main/database.hpp"

src/duckdb/src/planner/binder.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,6 @@ optional_ptr<Binding> Binder::GetMatchingBinding(const string &catalog_name, con
469469
const string &table_name, const string &column_name,
470470
ErrorData &error) {
471471
optional_ptr<Binding> binding;
472-
D_ASSERT(!lambda_bindings);
473472
if (macro_binding && table_name == macro_binding->GetAlias()) {
474473
binding = optional_ptr<Binding>(macro_binding.get());
475474
} else {

src/duckdb/src/planner/binder/expression/bind_macro_expression.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ void ExpressionBinder::UnfoldMacroExpression(FunctionExpression &function, Scala
9898
// validate the arguments and separate positional and default arguments
9999
vector<unique_ptr<ParsedExpression>> positional_arguments;
100100
InsertionOrderPreservingMap<unique_ptr<ParsedExpression>> named_arguments;
101+
binder.lambda_bindings = lambda_bindings;
101102
auto bind_result = MacroFunction::BindMacroFunction(binder, macro_func.macros, macro_func.name, function,
102103
positional_arguments, named_arguments, depth);
103104
if (!bind_result.error.empty()) {

0 commit comments

Comments
 (0)