Commit fcef7f9
[release/10.0] Defer DOTNET_DbgEnableMiniDump error message until dump creation (#126055)
Backport of #122986 to release/10.0
/cc @hoyosjs @Copilot
## Customer Impact
- [x] Customer reported
- [ ] Found internally
If customers specify the crash dump collecting variables on nativeAOT,
the default was to print error on startup to warn the user. It's also an
issue since we've moved tools like crossgen to nativeAOT, and setting
variables like this during build means child procs also prints the error
message - even if no crash is going to happen. This defers the message -
and while we are not proactive at letting the user know, it's a better
user experience for many cases where native AOT is used.
## Regression
- [ ] Yes
- [x] No
## Testing
Main has had this change for a while and is stable.
## Risk
Low. Changes eliminate unnecessary file system checks during
initialization and defer error detection to the point where the binary
is actually needed (execv call). The actual dump creation logic and all
success paths remain unchanged. Error messages now appear only when
dumps are actually attempted, preventing spurious warnings during
initialization.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: steveisok <471438+steveisok@users.noreply.github.com>
Co-authored-by: noahfalk <6243776+noahfalk@users.noreply.github.com>1 parent 7706f54 commit fcef7f9
1 file changed
Lines changed: 8 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
275 | 282 | | |
276 | 283 | | |
277 | 284 | | |
| |||
604 | 611 | | |
605 | 612 | | |
606 | 613 | | |
607 | | - | |
608 | | - | |
609 | | - | |
610 | | - | |
611 | | - | |
612 | | - | |
613 | 614 | | |
614 | 615 | | |
615 | 616 | | |
| |||
0 commit comments