Minimal SECURITY.md which is expected in github repos#936
Closed
schneidergithub wants to merge 1 commit into
Closed
Minimal SECURITY.md which is expected in github repos#936schneidergithub wants to merge 1 commit into
schneidergithub wants to merge 1 commit into
Conversation
A simple security policy, since I'm sure the owners of the repo will want to update this.
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider clarifying the scope of this policy (e.g., which projects or components are covered) so reporters know whether this contact applies to their finding.
- It would be helpful to include expected response timelines or what reporters can generally expect after contacting security@docker.com (acknowledgment, triage, etc.).
- If there are preferred formats or details for vulnerability reports (e.g., steps to reproduce, impact assessment), mentioning them here can improve report quality and reduce back-and-forth.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider clarifying the scope of this policy (e.g., which projects or components are covered) so reporters know whether this contact applies to their finding.
- It would be helpful to include expected response timelines or what reporters can generally expect after contacting security@docker.com (acknowledgment, triage, etc.).
- If there are preferred formats or details for vulnerability reports (e.g., steps to reproduce, impact assessment), mentioning them here can improve report quality and reduce back-and-forth.
## Individual Comments
### Comment 1
<location path="SECURITY.md" line_range="5" />
<code_context>
+
+## Reporting a Vulnerability
+
+Do not report vulnerabilities publicly, please contact security@docker.com
</code_context>
<issue_to_address>
**suggestion (typo):** Consider fixing the comma splice and adding proper sentence-ending punctuation.
This sentence joins two independent clauses with only a comma. Consider either: "Do not report vulnerabilities publicly. Please contact security@docker.com." or "Do not report vulnerabilities publicly; please contact security@docker.com."
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
@ericcurtin - I'm curious why this was closed? There is no security.md file, and at a bare minimum an email address would be useful to know, so people (like me) can submit security reports responsibly. I imagine a likely scenario is someone posting publicly a vulnerability in the repo's issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple security policy, since I'm sure the owners of the repo will want to update this.