fix(file): load existing unloaded buffer in _create_local_buffer#203
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves stability when rapidly switching between files by ensuring Diffview doesn’t reuse an existing unloaded file buffer (created by other plugins via bufadd()-style behavior) without first loading its contents from disk.
Changes:
- In
vcs.File:_create_local_buffer(), force-load an existing matching buffer viabufload()when it is currently unloaded. - Add a functional regression test covering the “pre-existing unloaded buffer” scenario for
RevType.LOCAL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/vcs/file.lua | Ensures reused LOCAL buffers are loaded from disk before diff rendering, preventing empty-placeholder reuse. |
| lua/diffview/tests/functional/file_spec.lua | Adds a regression test that reproduces an unloaded named buffer and verifies Diffview loads its content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes rapidly switching files (by pressing
<tab>/<s-tab>) much more stable.