fix(window): display loaded buffer even if file got deactivated mid-yield#202
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an async race during initial Diffview open where rapid <tab>/<s-tab> navigation can deactivate an in-flight file between Layout.open_files’ load loop and open loop, leaving a window stuck on the null placeholder and causing downstream cursor-jump failures.
Changes:
- Update
Window.open_file()to only gate loading onfile.active, but still display an already-loaded buffer even if the file became inactive mid-yield. - Add a functional regression test covering the “loaded-but-deactivated” window display case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/diffview/scene/window.lua | Adjusts Window.open_file() control flow to avoid leaving open_null displayed when the file buffer is already loaded but became inactive. |
| lua/diffview/tests/functional/window_spec.lua | Adds a regression test ensuring an already-loaded buffer is still displayed even if file.active=false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash that occurs if user hits
<tab>/<s-tab>rapidly when diffview first opens.