feat(jj): wire :DiffviewFileHistory to the JjAdapter#200
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds full :DiffviewFileHistory support to the Jujutsu (jj) adapter, enabling file-history views backed by jj log and aligning user-facing docs/completions/tests with the new capability (relates to issue sindrets#562).
Changes:
- Implement
jjfile-history option parsing, scope/canonicalization, streaming log worker, and per-commit parsing to produce DiffviewLogEntry/FileEntryobjects. - Introduce
JjCommitto correctly interpret jj timestamps/timezone offsets for consistent date rendering. - Update README + help docs and add functional/integration tests covering streaming, parsing, and glob/pathspec canonicalization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates supported VCS and adapter notes to reflect :DiffviewFileHistory support for jj and document unsupported features. |
| lua/diffview/vcs/adapters/jj/init.lua | Core implementation wiring jj file-history: options, scope resolution, streaming jj log template parsing, worker, flags, and completion. |
| lua/diffview/vcs/adapters/jj/commit.lua | Adds JjCommit subclass to compute time_offset and iso_date appropriately for jj-provided timestamps. |
| lua/diffview/tests/functional/jj_adapter_spec.lua | Adds functional/integration coverage for jj file-history streaming and parsing, including glob/pathspec canonicalization behavior. |
| doc/diffview.txt | Updates :DiffviewFileHistory help text and documents jj-specific options (--revisions, --limit, --reversed) and limitations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to sindrets#562.