Remove manual destroys

Author: dlunch

java_runtime/src/classes/java/io/byte_array_output_stream.rs

@@ -101,7 +101,6 @@ impl ByteArrayOutputStream {
                 .await?;
 
             jvm.put_field(this, "buf", "[B", new_buf.clone()).await?;
-            jvm.destroy(old_buf)?; // temporary before GC
         }
 
         Ok(())

java_runtime/src/classes/java/io/input_stream.rs

@@ -47,8 +47,6 @@ impl InputStream {
         let scratch = jvm.instantiate_array("B", n as _).await?;
         let _: i32 = jvm.invoke_virtual(&this, "read", "([BII)I", (scratch.clone(), 0, n as i32)).await?;
 
-        jvm.destroy(scratch)?;
-
         Ok(n)
     }
 }

java_runtime/src/classes/java/lang/string_buffer.rs

@@ -194,8 +194,6 @@ impl StringBuffer {
             let mut java_new_value_array = jvm.instantiate_array("C", new_capacity).await?;
             jvm.put_field(this, "value", "[C", java_new_value_array.clone()).await?;
             jvm.store_array(&mut java_new_value_array, 0, old_values).await?;
-
-            // jvm.destroy(java_value_array)?; // We shouldn't destroy this, this might be referenced by other objects
         }
 
         Ok(())

java_runtime/src/classes/java/net/url_class_loader.rs

@@ -110,8 +110,6 @@ impl URLClassLoader {
             )
             .await?;
 
-        jvm.destroy(bytes_java)?; // TODO: this should be done by the GC
-
         Ok(class)
     }
 

jvm/src/runtime/java_io_input_stream.rs

@@ -25,8 +25,6 @@ impl JavaIoInputStream {
             jvm.array_raw_buffer(&java_buffer).await?.read(0, &mut buffer[buffer_offset..])?;
         }
 
-        jvm.destroy(java_buffer)?; // TODO: this should be done automatically
-
         Ok(cast_vec(buffer))
     }
 }