We don't need create option

Author: dlunch

java_runtime/src/classes/java/io/file_input_stream.rs

@@ -36,7 +36,7 @@ impl FileInputStream {
         let path = jvm.invoke_virtual(&file, "getPath", "()Ljava/lang/String;", ()).await?;
         let path = JavaLangString::to_rust_string(jvm, &path).await?;
 
-        let rust_file = context.open(&path, false, false).await.unwrap();
+        let rust_file = context.open(&path, false).await.unwrap();
 
         let fd = FileDescriptor::from_file(jvm, rust_file).await?;
 

java_runtime/src/classes/java/io/file_output_stream.rs

@@ -42,7 +42,7 @@ impl FileOutputStream {
         let path = jvm.invoke_virtual(&file, "getPath", "()Ljava/lang/String;", ()).await?;
         let path = JavaLangString::to_rust_string(jvm, &path).await?;
 
-        let file = context.open(&path, true, true).await.unwrap();
+        let file = context.open(&path, true).await.unwrap();
         let fd = FileDescriptor::from_file(jvm, file).await?;
 
         jvm.put_field(&mut this, "fd", "Ljava/io/FileDescriptor;", fd).await?;

java_runtime/src/classes/java/io/random_access_file.rs

@@ -53,9 +53,9 @@ impl RandomAccessFile {
         let name = JavaLangString::to_rust_string(jvm, &name).await?;
         let mode = JavaLangString::to_rust_string(jvm, &mode).await?;
 
-        let create = mode.contains('w');
+        let write = mode.contains('w');
 
-        let rust_file = context.open(&name, create, create).await.unwrap();
+        let rust_file = context.open(&name, write).await.unwrap();
         let fd = FileDescriptor::from_file(jvm, rust_file).await?;
         jvm.put_field(&mut this, "fd", "Ljava/io/FileDescriptor;", fd).await?;
 

java_runtime/src/runtime.rs

@@ -27,7 +27,7 @@ pub trait Runtime: Sync + Send + DynClone {
     fn stdout(&self) -> IOResult<Box<dyn File>>;
     fn stderr(&self) -> IOResult<Box<dyn File>>;
 
-    async fn open(&self, path: &str, write: bool, create: bool) -> IOResult<Box<dyn File>>;
+    async fn open(&self, path: &str, write: bool) -> IOResult<Box<dyn File>>;
     async fn unlink(&self, path: &str) -> IOResult<()>;
     async fn metadata(&self, path: &str) -> IOResult<FileStat>;
 
@@ -117,7 +117,7 @@ pub mod test {
             Err(IOError::NotFound)
         }
 
-        async fn open(&self, path: &str, _write: bool, _create: bool) -> IOResult<Box<dyn File>> {
+        async fn open(&self, path: &str, _write: bool) -> IOResult<Box<dyn File>> {
             let entry = self.filesystem.get(path);
             if let Some(data) = entry {
                 Ok(Box::new(DummyFile::new(data.clone())) as Box<_>)

src/runtime.rs

@@ -116,8 +116,8 @@ where
         Ok(Box::new(WriteStreamFile::new(stderr())))
     }
 
-    async fn open(&self, path: &str, write: bool, create: bool) -> IOResult<Box<dyn File>> {
-        Ok(Box::new(FileImpl::new(path, write, create)))
+    async fn open(&self, path: &str, write: bool) -> IOResult<Box<dyn File>> {
+        Ok(Box::new(FileImpl::new(path, write)))
     }
 
     async fn unlink(&self, path: &str) -> IOResult<()> {

src/runtime/io.rs

@@ -131,9 +131,9 @@ pub struct FileImpl {
 }
 
 impl FileImpl {
-    pub fn new(path: &str, write: bool, create: bool) -> Self {
+    pub fn new(path: &str, write: bool) -> Self {
         let mut options = OpenOptions::new();
-        let file = options.read(true).write(write).create(create).open(path).unwrap();
+        let file = options.read(true).write(write).create(write).open(path).unwrap();
 
         Self {
             file: Arc::new(Mutex::new(file)),