Skip to content

Commit d79adbb

Browse files
committed
Fix bugs on macOS
1 parent 21c9644 commit d79adbb

File tree

17 files changed

+43
-32
lines changed

17 files changed

+43
-32
lines changed

src/libs/application/dspxmodel/tests/dspx/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ int main(int argc, char **argv) {
4747
// Test TrackList functionality
4848
qDebug() << "=== Testing TrackList ===";
4949

50-
auto trackList = model.trackList();
50+
auto trackList = model.tracks();
5151
qDebug() << "Initial track count:" << trackList->size();
5252

5353
// Create some tracks

src/libs/application/uishell/src/qml/ProjectWindow.qml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ Window {
6565
windowAgent.setSystemButton(WindowAgent.Close, closeSystemButton)
6666
windowAgent.setSystemButton(WindowAgent.WindowIcon, iconArea)
6767
windowAgent.setHitTestVisible(Overlay.overlay)
68+
windowAgent.setHitTestVisible(leftToolBarContainer)
69+
windowAgent.setHitTestVisible(rightToolBarContainer)
70+
windowAgent.setHitTestVisible(middleToolBarContainer)
6871
}
6972
}
7073

@@ -172,7 +175,8 @@ Window {
172175
Item {
173176
id: titleBarArea
174177
Layout.fillWidth: true
175-
Layout.fillHeight: true
178+
Layout.fillHeight: !window.isMacOS
179+
Layout.preferredHeight: window.isMacOS ? titleBar.height + toolBar.height : undefined
176180
RowLayout {
177181
anchors.right: parent.right
178182
visible: !window.isMacOS
@@ -231,7 +235,9 @@ Window {
231235
color: parent.color
232236
}
233237
}
234-
PaneSeparator {}
238+
PaneSeparator {
239+
visible: !window.isMacOS
240+
}
235241
Rectangle {
236242
id: separatedMenuParent
237243
Layout.fillWidth: true

src/plugins/audio/internal/AudioPlugin.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414

1515
#include <coreplugin/CoreInterface.h>
1616

17-
#include <audio/internal/audioandmidipage.h>
18-
#include <audio/internal/audiooutputpage.h>
19-
#include <audio/internal/audiosystem.h>
20-
#include <audio/internal/outputsystem.h>
17+
#include <audio/internal/AudioAndMidiPage.h>
18+
#include <audio/internal/AudioOutputPage.h>
19+
#include <audio/internal/AudioSystem.h>
20+
#include <audio/internal/OutputSystem.h>
2121

2222
namespace Audio::Internal {
2323

src/plugins/audio/internal/AudioSystem.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#include "AudioSystem.h"
22

3-
#include <audio/internal/outputsystem.h>
3+
#include <audio/internal/OutputSystem.h>
44

55
namespace Audio::Internal {
66

src/plugins/audio/internal/dialogs/AudioTroubleshootingDialog.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
#include <QPlainTextEdit>
1212
#include <QVBoxLayout>
1313

14-
#include <audio/internal/audiooutputsettingshelper.h>
15-
#include <audio/internal/audiosystem.h>
16-
#include <audio/internal/outputsystem.h>
14+
#include <audio/internal/AudioOutputSettingsHelper.h>
15+
#include <audio/internal/AudioSystem.h>
16+
#include <audio/internal/OutputSystem.h>
1717

1818
namespace Audio::Internal {
1919

src/plugins/audio/internal/settings/AudioOutputPage.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
#include <CoreApi/runtimeinterface.h>
88

9-
#include <audio/internal/audiooutputsettingshelper.h>
9+
#include <audio/internal/AudioOutputSettingsHelper.h>
1010

1111
namespace Audio::Internal {
1212

src/plugins/audio/internal/utils/AudioOutputSettingsHelper.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
#include <TalcsDevice/AudioDriver.h>
1111
#include <TalcsDevice/AudioDriverManager.h>
1212

13-
#include <audio/internal/audiosystem.h>
14-
#include <audio/internal/outputsystem.h>
13+
#include <audio/internal/AudioSystem.h>
14+
#include <audio/internal/OutputSystem.h>
1515

1616
namespace Audio::Internal {
1717

src/plugins/coreplugin/qml/actions/GlobalActions.qml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,15 @@ import DiffScope.UIShell
1111
import DiffScope.Core
1212

1313
ActionCollection {
14+
id: d
15+
16+
required property ActionWindowInterfaceBase windowHandle
1417

1518
ActionItem {
1619
actionId: "org.diffscope.core.file.new"
1720
Action {
1821
onTriggered: (o) => {
19-
CoreInterface.newFile(o?.Window.window ?? null)
22+
CoreInterface.newFile(d.windowHandle.window)
2023
}
2124
}
2225
}
@@ -25,7 +28,7 @@ ActionCollection {
2528
actionId: "org.diffscope.core.file.newFromTemplate"
2629
Action {
2730
onTriggered: (o) => {
28-
CoreInterface.newFileFromTemplate("", o?.Window.window ?? null)
31+
CoreInterface.newFileFromTemplate("", d.windowHandle.window)
2932
}
3033
}
3134
}
@@ -34,7 +37,7 @@ ActionCollection {
3437
actionId: "org.diffscope.core.file.open"
3538
Action {
3639
onTriggered: (o) => {
37-
CoreInterface.openFile("", o?.Window.window ?? null)
40+
CoreInterface.openFile("", d.windowHandle.window)
3841
}
3942
}
4043
}
@@ -52,7 +55,7 @@ ActionCollection {
5255
actionId: "org.diffscope.core.settings"
5356
Action {
5457
onTriggered: (o) => {
55-
let w = o.Window.window
58+
let w = d.windowHandle.window
5659
Qt.callLater(() => CoreInterface.execSettingsDialog("", w))
5760
}
5861
}
@@ -62,7 +65,7 @@ ActionCollection {
6265
actionId: "org.diffscope.core.plugins"
6366
Action {
6467
onTriggered: (o) => {
65-
let w = o.Window.window
68+
let w = d.windowHandle.window
6669
Qt.callLater(() => CoreInterface.execPluginsDialog(w))
6770
}
6871
}
@@ -90,7 +93,7 @@ ActionCollection {
9093
actionId: "org.diffscope.core.aboutApp"
9194
Action {
9295
onTriggered: (o) => {
93-
let w = o.Window.window
96+
let w = d.windowHandle.window
9497
Qt.callLater(() => CoreInterface.execAboutAppDialog(w))
9598
}
9699
}
@@ -100,7 +103,7 @@ ActionCollection {
100103
actionId: "org.diffscope.core.aboutQt"
101104
Action {
102105
onTriggered: (o) => {
103-
let w = o.Window.window
106+
let w = d.windowHandle.window
104107
Qt.callLater(() => CoreInterface.execAboutQtDialog(w))
105108
}
106109
}

src/plugins/coreplugin/windows/ActionWindowInterfaceBase.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,9 @@ namespace Core {
4747
if (component.isError()) {
4848
qFatal() << component.errorString();
4949
}
50-
auto o = component.create();
50+
auto o = component.createWithInitialProperties({
51+
{"windowHandle", QVariant::fromValue(q)}
52+
});
5153
o->setParent(q);
5254
QMetaObject::invokeMethod(o, "registerToContext", actionContext);
5355
}

0 commit comments

Comments
 (0)