Update visualeditor icons

Author: CrSjimo

src/plugins/coreplugin/internal/CorePlugin.cpp

@@ -298,9 +298,6 @@ namespace Core::Internal {
             icon.addUrl("image://fluent-system-icons/" + iconName);
             CoreInterface::actionRegistry()->addIcon("", id, icon);
         };
-        addIcon("org.diffscope.visualeditor.panel.arrangement", "gantt_chart");
-        addIcon("org.diffscope.visualeditor.panel.mixer", "options_vertical");
-        addIcon("org.diffscope.visualeditor.panel.pianoRoll", "midi");
     }
 
     void CorePlugin::initializeSettings() const {

src/plugins/visualeditor/CMakeLists.txt

@@ -41,3 +41,11 @@ diffscope_add_builtin_plugin(${PROJECT_NAME}
     INCLUDE_PRIVATE
         internal/**
 )
+
+file(GLOB _res_icons res/icons/*)
+
+qt_add_resources(${PROJECT_NAME} icons
+    PREFIX /diffscope/visualeditor/icons
+    BASE res/icons
+    FILES ${_res_icons}
+)

src/plugins/visualeditor/qml/SnapControl.qml

@@ -37,7 +37,7 @@ Item {
             ]
             textRole: "text"
             valueRole: "data"
-            Component.onCompleted: currentValue = Qt.binding(() => control.positionAlignmentManipulator?.duration ?? 0)
+            Component.onCompleted: currentIndex = Qt.binding(() => indexOfValue(control.positionAlignmentManipulator?.duration ?? 0))
             onCurrentValueChanged: () => {
                 if (control.positionAlignmentManipulator) {
                     control.positionAlignmentManipulator.duration = currentValue
@@ -46,7 +46,8 @@ Item {
         }
         ToolButton {
             text: qsTr("Triplet")
-            // display: AbstractButton.IconOnly
+            display: AbstractButton.IconOnly
+            icon.source: "qrc:/diffscope/visualeditor/icons/triplet.svg"
             checkable: true
             checked: control.positionAlignmentManipulator?.tuplet === PositionAlignmentManipulator.Triplet
             onClicked: () => {
@@ -57,7 +58,8 @@ Item {
         }
         ToolButton {
             text: qsTr("Quintuplet")
-            // display: AbstractButton.IconOnly
+            display: AbstractButton.IconOnly
+            icon.source: "qrc:/diffscope/visualeditor/icons/quintuplet.svg"
             checkable: true
             checked: control.positionAlignmentManipulator?.tuplet === PositionAlignmentManipulator.Quintuplet
             onClicked: () => {

src/plugins/visualeditor/res/icons/quintuplet.svg

@@ -15,14 +15,14 @@
     </configuration>
 
     <items>
-        <action id="org.diffscope.visualeditor.arrangementPanel.pointerTool" shortcut="F5" />
-        <action id="org.diffscope.visualeditor.arrangementPanel.pencilTool" shortcut="F6" />
-        <action id="org.diffscope.visualeditor.arrangementPanel.handTool" shortcut="F7" />
+        <action id="org.diffscope.visualeditor.arrangementPanel.pointerTool" icon="cursor" shortcut="F5" />
+        <action id="org.diffscope.visualeditor.arrangementPanel.pencilTool" icon="edit" shortcut="F6" />
+        <action id="org.diffscope.visualeditor.arrangementPanel.handTool" icon="hand_left" shortcut="F7" />
         <action id="org.diffscope.visualeditor.arrangementPanel.alignment" diffscope:excludeFromCommands="true" />
 
-        <action id="org.diffscope.visualeditor.panel.arrangement" catalog="org.diffscope.core.workspacePanelWidgets" diffscope:excludeFromCommands="true"/>
-        <action id="org.diffscope.visualeditor.panel.mixer" catalog="org.diffscope.core.workspacePanelWidgets" diffscope:excludeFromCommands="true"/>
-        <action id="org.diffscope.visualeditor.panel.pianoRoll" catalog="org.diffscope.core.workspacePanelWidgets" diffscope:excludeFromCommands="true"/>
+        <action id="org.diffscope.visualeditor.panel.arrangement" catalog="org.diffscope.core.workspacePanelWidgets" icon="gantt_chart" diffscope:excludeFromCommands="true"/>
+        <action id="org.diffscope.visualeditor.panel.mixer" catalog="org.diffscope.core.workspacePanelWidgets" icon="options_vertical" diffscope:excludeFromCommands="true"/>
+        <action id="org.diffscope.visualeditor.panel.pianoRoll" catalog="org.diffscope.core.workspacePanelWidgets" icon="midi" diffscope:excludeFromCommands="true"/>
     </items>
 
     <layouts>