Skip to content

Commit 6235c2a

Browse files
committed
MNT: use more specific variable name
1 parent 1f788d7 commit 6235c2a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/diffpy/structure/tests/testp_cif.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def test_getSymOp(self):
6666

6767
class TestP_cif(unittest.TestCase):
6868

69-
goodciffile = datafile('PbTe.cif')
69+
pbteciffile = datafile('PbTe.cif')
7070
badciffile = datafile('LiCl-bad.cif')
7171
graphiteciffile = datafile('graphite.cif')
7272
cdsebulkpdffitfile = datafile('CdSe_bulk.stru')
@@ -86,12 +86,12 @@ def tearDown(self):
8686
def test_parse(self):
8787
"""check P_cif.parse()
8888
"""
89-
with open(self.goodciffile) as fp1:
89+
with open(self.pbteciffile) as fp1:
9090
sgood = fp1.read()
9191
with open(self.badciffile) as fp2:
9292
sbad = fp2.read()
9393
pfile, ptest = self.pfile, self.ptest
94-
stru_check = pfile.parseFile(self.goodciffile)
94+
stru_check = pfile.parseFile(self.pbteciffile)
9595
stru = ptest.parse(sgood)
9696
self.assertEqual(str(stru_check), str(stru))
9797
self.assertEqual(str(stru_check.lattice), str(stru.lattice))
@@ -106,12 +106,12 @@ def test_parse(self):
106106
def test_parseLines(self):
107107
"""check P_cif.parseLines()
108108
"""
109-
with open(self.goodciffile) as fp1:
109+
with open(self.pbteciffile) as fp1:
110110
goodlines = fp1.readlines()
111111
with open(self.badciffile) as fp2:
112112
badlines = fp2.readlines()
113113
pfile, ptest = self.pfile, self.ptest
114-
stru_check = pfile.parseFile(self.goodciffile)
114+
stru_check = pfile.parseFile(self.pbteciffile)
115115
stru = ptest.parseLines(goodlines)
116116
self.assertEqual(str(stru_check), str(stru))
117117
self.assertEqual(str(stru_check.lattice), str(stru.lattice))
@@ -126,8 +126,8 @@ def test_parseLines(self):
126126
def test_parseFile(self):
127127
"""check P_cif.parseFile()
128128
"""
129-
# goodciffile
130-
stru = self.pfile.parseFile(self.goodciffile)
129+
# pbteciffile
130+
stru = self.pfile.parseFile(self.pbteciffile)
131131
self.assertEqual(8, len(stru))
132132
self.assertEqual(6.461, stru.lattice.a)
133133
self.assertEqual(6.461, stru.lattice.b)

0 commit comments

Comments
 (0)