create conda env in pytest fixture

Author: cadenmyers13

tests/conftest.py

@@ -1,10 +1,26 @@
 import json
+import subprocess
 from pathlib import Path
 
 import matplotlib
 import pytest
 
 
+@pytest.fixture(scope="function")
+def conda_env(tmp_path):
+    env_dir = tmp_path / "fake_env"
+    env_dir_str = env_dir.as_posix()
+    subprocess.run(
+        ["conda", "create", "-y", "-p", env_dir_str],
+        check=True,
+        capture_output=True,
+    )
+    yield env_dir_str
+    subprocess.run(
+        ["conda", "env", "remove", "-p", env_dir_str, "-y"], check=True
+    )
+
+
 @pytest.fixture(scope="function")
 def example_cases(tmp_path_factory):
     """Copy the entire examples tree into a temp directory once per test

tests/test_packsmanager.py

@@ -1,6 +1,5 @@
 import os
 import re
-import shutil
 import subprocess
 from pathlib import Path
 
@@ -373,44 +372,23 @@ def test_copy_examples_force(example_cases, expected_paths, force):
 
 @pytest.mark.parametrize("packs_to_install,expected", install_params)
 def test_print_packs_and_examples(
-    packs_to_install, expected, example_cases, capsys
+    packs_to_install, expected, example_cases, capsys, conda_env
 ):
-    case5dir = example_cases / "case5"
-    env_dir = case5dir / "fake_env"
-    req_dir = case5dir / "requirements" / "packs"
-    # Handle Windows path format
-    env_dir_str = env_dir.as_posix()
+    env_dir_str = Path(conda_env).as_posix()
     shell = os.name == "nt"
-    try:
+    req_dir = example_cases / "case5" / "requirements" / "packs"
+    for pack in packs_to_install:
+        req_file = (req_dir / f"{pack}.txt").as_posix()
         subprocess.run(
-            ["conda", "create", "-y", "-p", env_dir_str],
+            ["conda", "install", "-y", "--file", req_file, "-p", env_dir_str],
             check=True,
             capture_output=True,
             text=True,
             shell=shell,
         )
-        for pack in packs_to_install:
-            req_file = (req_dir / f"{pack}.txt").as_posix()
-            subprocess.run(
-                [
-                    "conda",
-                    "install",
-                    "-y",
-                    "--file",
-                    req_file,
-                    "-p",
-                    env_dir_str,
-                ],
-                check=True,
-                capture_output=True,
-                text=True,
-                shell=shell,
-            )
-        pm = PacksManager(root_path=case5dir)
-        pm.print_packs()
-        pm.print_examples()
-        captured = capsys.readouterr()
-        actual = captured.out
-        assert actual.strip() == expected.strip()
-    finally:
-        shutil.rmtree(env_dir, ignore_errors=True)
+    pm = PacksManager(root_path=example_cases / "case5")
+    pm.print_packs()
+    pm.print_examples()
+    captured = capsys.readouterr()
+    actual = captured.out
+    assert actual.strip() == expected.strip()