Skip to content

Commit e588653

Browse files
WIP: remove automatic csv dump and fix small typo in globalRegistration.hh
1 parent c40590f commit e588653

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/diffCheck/registration/globalregistration.hh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class GlobalRegistration
4646
int maxTupleCount = 500);
4747

4848
/**
49-
Very little information on this registration method compared to the previous one.
49+
Little information on this registration method compared to the previous one.
5050
If I understand correctly, this method finds keypoints in the FPFH hyperspaces of the source and target point clouds and then tries to match them.
5151
https://pcl.readthedocs.io/projects/tutorials/en/latest/correspondence_grouping.html
5252
@@ -72,7 +72,7 @@ class GlobalRegistration
7272
Then, a transformation is computed that minimizes the error between the correspondances.
7373
If the error is above a certain threshold, the transformation is discarded and a new one is computed.
7474
75-
In practice, Open3D gives little information about the feature correspondence
75+
In practice, Open3D gives little information about the feature correspondence, compared to the FGR methods
7676
7777
@param source the source point cloud
7878
@param target the target point cloud

src/diffCheckApp.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ int iterations = 50;
139139
devisu.Run();
140140
}
141141
}
142-
143-
// write the errors and computation times to 2 csv files with one column per method
142+
/*
143+
// write the errors and computation times to 2 csv files with one column per method
144144
std::ofstream fileErrors("errors.csv");
145145
std::ofstream fileTimes("times.csv");
146146
fileErrors<<"FGR Feature Matching,FGR Correspondance,Ransac Correspondance,Ransac Feature Matching"<<std::endl;
@@ -152,5 +152,7 @@ int iterations = 50;
152152
}
153153
fileErrors.close();
154154
fileTimes.close();
155+
*/
156+
155157
return 0;
156158
}

0 commit comments

Comments
 (0)