FIX: small modification of naming for GetAxixAlignedBoundingBox for more consistency

Author: DamienGilliard

src/diffCheck/geometry/DFPointCloud.cc

@@ -116,7 +116,7 @@ namespace diffCheck::geometry
         return cilantroPointCloud;
     }
 
-    std::vector<Eigen::Vector3d> DFPointCloud::ComputeBoundingBox()
+    std::vector<Eigen::Vector3d> DFPointCloud::GetAxixAlignedBoundingBox()
     {
         auto O3DPointCloud = this->Cvt2O3DPointCloud();
         auto boundingBox = O3DPointCloud->GetAxisAlignedBoundingBox();

src/diffCheck/geometry/DFPointCloud.hh

@@ -54,7 +54,7 @@ namespace diffCheck::geometry
          * @return std::vector<Eigen::Vector3d> A vector of two Eigen::Vector3d, with the first one being the minimum
          *  point and the second one the maximum point of the bounding box.
         */
-        std::vector<Eigen::Vector3d> ComputeBoundingBox();
+        std::vector<Eigen::Vector3d> GetAxixAlignedBoundingBox();
 
         /**
          * @brief Estimate the normals of the point cloud by either knn or if the radius

src/diffCheck/registrations/DFRefinedRegistration.cc

@@ -13,7 +13,7 @@ namespace diffCheck::registrations
         int maxIteration,
         bool usePointToPlane)
     {
-        std::vector<Eigen::Vector3d> minMax = source->ComputeBoundingBox();
+        std::vector<Eigen::Vector3d> minMax = source->GetAxixAlignedBoundingBox();
 
         std::shared_ptr<open3d::geometry::PointCloud> O3Dsource = source->Cvt2O3DPointCloud();
         std::shared_ptr<open3d::geometry::PointCloud> O3Dtarget = target->Cvt2O3DPointCloud();
@@ -65,7 +65,7 @@ namespace diffCheck::registrations
             double relativeFitness,
             double relativeRMSE)
     {
-        std::vector<Eigen::Vector3d> minMax = source->ComputeBoundingBox();
+        std::vector<Eigen::Vector3d> minMax = source->GetAxixAlignedBoundingBox();
 
         std::shared_ptr<open3d::geometry::PointCloud> O3Dsource = source->Cvt2O3DPointCloud();
         std::shared_ptr<open3d::geometry::PointCloud> O3Dtarget = target->Cvt2O3DPointCloud();

src/diffCheckBindings.cc

@@ -31,7 +31,6 @@ PYBIND11_MODULE(diffcheck_bindings, m) {
 
         .def("compute_distance", &diffCheck::geometry::DFPointCloud::ComputeDistance,
             py::arg("target_cloud"))
-        .def("compute_BoundingBox", &diffCheck::geometry::DFPointCloud::ComputeBoundingBox)
 
         .def("voxel_downsample", &diffCheck::geometry::DFPointCloud::VoxelDownsample,
             py::arg("voxel_size"))
@@ -55,6 +54,7 @@ PYBIND11_MODULE(diffcheck_bindings, m) {
         .def("add_points", &diffCheck::geometry::DFPointCloud::AddPoints)  
 
         .def("get_tight_bounding_box", &diffCheck::geometry::DFPointCloud::GetTightBoundingBox)
+        .def("get_axis_aligned_bounding_box", &diffCheck::geometry::DFPointCloud::GetAxixAlignedBoundingBox)
 
         .def("get_num_points", &diffCheck::geometry::DFPointCloud::GetNumPoints)
         .def("get_num_colors", &diffCheck::geometry::DFPointCloud::GetNumColors)

tests/unit_tests/DFPointCloudTest.cc

@@ -118,7 +118,7 @@ TEST_F(DFPointCloudTestFixture, ComputeDistance) {
 }
 
 TEST_F(DFPointCloudTestFixture, ComputeAABB) {
-    std::vector<Eigen::Vector3d> bbox = dfPointCloud.ComputeBoundingBox();
+    std::vector<Eigen::Vector3d> bbox = dfPointCloud.GetAxixAlignedBoundingBox();
     EXPECT_EQ(bbox.size(), 2);
 }