fix: simplify cropping component

Author: DamienGilliard

src/gh/components/DF_crop_cloud/code.py

@@ -12,13 +12,7 @@ def __init__(self):
         super(DFCloudCrop, self).__init__()
     def RunScript(self,
             i_cloud: Rhino.Geometry.PointCloud,
-            i_box: Rhino.Geometry.Brep,
-            i_x_min: float,
-            i_y_min: float,
-            i_z_min: float,
-            i_x_max: float,
-            i_y_max: float,
-            i_z_max: float):
+            i_box: Rhino.Geometry.Brep):
         if i_cloud is None:
             ghenv.Component.AddRuntimeMessage(RML.Warning, "No point cloud provided. Please connect a point cloud to the input.")  # noqa: F821
             return None
@@ -28,22 +22,9 @@ def RunScript(self,
             bb_min_as_array = np.asarray([bbox.Min.X, bbox.Min.Y, bbox.Min.Z])
             bb_max_as_array = np.asarray([bbox.Max.X, bbox.Max.Y, bbox.Max.Z])
 
-            ghenv.Component.AddRuntimeMessage(RML.Remark, "A box is provided and is used to crop the point cloud, all other inputs neglected. To use min/max values, disconnect the box")  # noqa: F821
         else:
-            if i_x_min is None:
-                i_x_min = -np.inf
-            if i_y_min is None:
-                i_y_min = -np.inf
-            if i_z_min is None:
-                i_z_min = -np.inf
-            if i_x_max is None:
-                i_x_max = np.inf
-            if i_y_max is None:
-                i_y_max = np.inf
-            if i_z_max is None:
-                i_z_max = np.inf
-            bb_min_as_array = np.asarray([i_x_min, i_y_min, i_z_min])
-            bb_max_as_array = np.asarray([i_x_max, i_y_max, i_z_max])
+            ghenv.Component.AddRuntimeMessage(RML.Warning, "Please provide a box to crop the point cloud with")  # noqa: F821
+
         df_cloud = df_cvt.cvt_rhcloud_2_dfcloud(i_cloud)
         df_cloud.crop(bb_min_as_array, bb_max_as_array)
         rh_cloud = df_cvt.cvt_dfcloud_2_rhcloud(df_cloud)

src/gh/components/DF_crop_cloud/metadata.json

@@ -17,7 +17,7 @@
                 "name": "i_cloud",
                 "nickname": "i_cloud",
                 "description": "The point cloud to crop.",
-                "optional": true,
+                "optional": false,
                 "allowTreeAccess": true,
                 "showTypeHints": true,
                 "scriptParamAccess": "item",
@@ -29,85 +29,13 @@
                 "name": "i_box",
                 "nickname": "i_box",
                 "description": "The brep box to crop the point cloud with.",
-                "optional": true,
+                "optional": false,
                 "allowTreeAccess": true,
                 "showTypeHints": true,
                 "scriptParamAccess": "item",
                 "wireDisplay": "default",
                 "sourceCount": 0,
                 "typeHintID": "brep"
-            },
-            {
-                "name": "i_x_min",
-                "nickname": "i_x_min",
-                "description": "The minimum x value to crop the point cloud with.",
-                "optional": true,
-                "allowTreeAccess": true,
-                "showTypeHints": true,
-                "scriptParamAccess": "item",
-                "wireDisplay": "default",
-                "sourceCount": 0,
-                "typeHintID": "float"
-            },
-            {
-                "name": "i_y_min",
-                "nickname": "i_y_min",
-                "description": "The minimum y value to crop the point cloud with.",
-                "optional": true,
-                "allowTreeAccess": true,
-                "showTypeHints": true,
-                "scriptParamAccess": "item",
-                "wireDisplay": "default",
-                "sourceCount": 0,
-                "typeHintID": "float"
-            },
-            {
-                "name": "i_z_min",
-                "nickname": "i_z_min",
-                "description": "The minimum z value to crop the point cloud with.",
-                "optional": true,
-                "allowTreeAccess": true,
-                "showTypeHints": true,
-                "scriptParamAccess": "item",
-                "wireDisplay": "default",
-                "sourceCount": 0,
-                "typeHintID": "float"
-            },
-            {
-                "name": "i_x_max",
-                "nickname": "i_x_max",
-                "description": "The maximum x value to crop the point cloud with.",
-                "optional": true,
-                "allowTreeAccess": true,
-                "showTypeHints": true,
-                "scriptParamAccess": "item",
-                "wireDisplay": "default",
-                "sourceCount": 0,
-                "typeHintID": "float"
-            },
-            {
-                "name": "i_y_max",
-                "nickname": "i_y_max",
-                "description": "The maximum y value to crop the point cloud with.",
-                "optional": true,
-                "allowTreeAccess": true,
-                "showTypeHints": true,
-                "scriptParamAccess": "item",
-                "wireDisplay": "default",
-                "sourceCount": 0,
-                "typeHintID": "float"
-            },
-            {
-                "name": "i_z_max",
-                "nickname": "i_z_max",
-                "description": "The maximum z value to crop the point cloud with.",
-                "optional": true,
-                "allowTreeAccess": true,
-                "showTypeHints": true,
-                "scriptParamAccess": "item",
-                "wireDisplay": "default",
-                "sourceCount": 0,
-                "typeHintID": "float"
             }
         ],
         "outputParameters": [