fix: make variable names coherent-er

Author: DamienGilliard

src/gh/components/DF_CAD_segmentator/code.py

@@ -30,7 +30,6 @@ def RunScript(self,
         if i_association_threshold is None:
             i_association_threshold = 0.1
 
-        o_aggregated_clusters = []
         o_face_clusters = []
         df_clusters = []
         # we make a deepcopy of the input clouds
@@ -74,13 +73,13 @@ def RunScript(self,
 
             df_clusters.append(df_asssociated_cluster)
 
-        o_aggregated_clusters = [df_cvt_bindings.cvt_dfcloud_2_rhcloud(cluster) for cluster in df_clusters]
+        o_beam_clouds = [df_cvt_bindings.cvt_dfcloud_2_rhcloud(cluster) for cluster in df_clusters]
 
-        for o_aggregated_cluster in o_aggregated_clusters:
-            if not o_aggregated_cluster.IsValid:
-                o_aggregated_cluster = None
+        for o_beam_cloud in o_beam_clouds:
+            if not o_beam_cloud.IsValid:
+                o_beam_cloud = None
                 ghenv.Component.AddRuntimeMessage(RML.Warning, "Some beams could not be segmented and were replaced by 'None'")  # noqa: F821
 
-        o_face_clusters = th.list_to_tree(o_face_clusters)
+        o_face_clouds = th.list_to_tree(o_face_clusters)
 
-        return o_aggregated_clusters, o_face_clusters
+        return [o_beam_clouds, o_face_clouds]

src/gh/components/DF_CAD_segmentator/metadata.json

@@ -64,17 +64,17 @@
         ],
         "outputParameters": [
             {
-                "name": "o_clusters",
-                "nickname": "o_clusters",
-                "description": "The clouds associated to each beam.",
+                "name": "o_beam_clouds",
+                "nickname": "o_beam_clouds",
+                "description": "The merged clouds associated to each beam.",
                 "optional": false,
                 "sourceCount": 0,
                 "graft": false
             },
             {
-                "name": "o_face_clusters",
-                "nickname": "o_face_clusters",
-                "description": "The clouds associated to each face.",
+                "name": "o_face_clouds",
+                "nickname": "o_face_clouds",
+                "description": "The datatree of clouds associated to each face.",
                 "optional": false,
                 "sourceCount": 0,
                 "graft": false

src/gh/components/DF_pose_estimation/code.py

@@ -15,12 +15,12 @@
 
 class DFPoseEstimation(component):
     def RunScript(self,
-            i_face_clusters: Grasshopper.DataTree[Rhino.Geometry.PointCloud],
+            i_face_clouds: Grasshopper.DataTree[Rhino.Geometry.PointCloud],
             i_assembly,
             i_reset: bool,
             i_save: bool):
 
-        clusters_per_beam = th.tree_to_list(i_face_clusters)
+        clusters_per_beam = th.tree_to_list(i_face_clouds)
         # ensure assembly has enough beams
         if len(i_assembly.beams) < len(clusters_per_beam):
             ghenv.Component.AddRuntimeMessage(RML.Warning, "Assembly has fewer beams than input clouds")  # noqa: F821

src/gh/components/DF_pose_estimation/metadata.json

@@ -14,9 +14,9 @@
         "iconDisplay": 2,
         "inputParameters": [
             {
-                "name": "i_face_clusters",
-                "nickname": "i_face_clusters",
-                "description": "clouds whose pose is to be calculated",
+                "name": "i_face_clouds",
+                "nickname": "i_face_clouds",
+                "description": "datatree of beam clouds whose pose is to be calculated",
                 "optional": false,
                 "allowTreeAccess": true,
                 "showTypeHints": true,