Skip to content

Commit 673b159

Browse files
committed
FIX-TYPO
1 parent 1dba340 commit 673b159

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/diffCheck/segmentation/DFSegmentation.hh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace diffCheck::segmentation
2727

2828
public: ///< segmentation refinement methods
2929
/** @brief Associates point cloud segments to mesh faces and merges them. It uses the center of mass of the segments and the mesh faces to find correspondances. For each mesh face it then iteratively associate the points of the segment that are actually on the mesh face.
30-
* @param referenceMesh the vector of mesh faces to associate with the segments
30+
* @param referenceMesh the vector of mesh faces to associate with the segments. It is a representation of a beam and its faces.
3131
* @param clusters the vector of clusters from cilantro to associate with the mesh faces of the reference mesh
3232
* @param angleThreshold the threshold to consider the a cluster as potential candidate for association. the value passed is the minimum sine of the angles. A value of 0 requires perfect alignment (angle = 0), while a value of 0.1 allows an angle of 5.7 degrees.
3333
* @param associationThreshold the threshold to consider the points of a segment and a mesh face as associable. It is the ratio between the surface of the closest mesh triangle and the sum of the areas of the three triangles that form the rest of the pyramid described by the mesh triangle and the point we want to associate or not. The lower the number, the more strict the association will be and some poinnts on the mesh face might be wrongfully excluded.
@@ -42,17 +42,18 @@ namespace diffCheck::segmentation
4242
/** @brief Iterated through clusters and finds the corresponding mesh face. It then associates the points of the cluster that are on the mesh face to the segment already associated with the mesh face.
4343
* @param unassociatedClusters the clusters from the normal-based segmentatinon that haven't been associated yet.
4444
* @param existingPointCloudSegments the already associated segments
45-
* @param Meshes the mesh faces for all the model. This is used to associate the clusters to the mesh faces.
45+
* @param meshes the mesh faces for all the model. This is used to associate the clusters to the mesh faces.
4646
* * @param angleThreshold the threshold to consider the a cluster as potential candidate for association. the value passed is the minimum sine of the angles. A value of 0 requires perfect alignment (angle = 0), while a value of 0.1 allows an angle of 5.7 degrees.
4747
* @param associationThreshold the threshold to consider the points of a segment and a mesh face as associable. It is the ratio between the surface of the closest mesh triangle and the sum of the areas of the three triangles that form the rest of the pyramid described by the mesh triangle and the point we want to associate or not. The lower the number, the more strict the association will be and some poinnts on the mesh face might be wrongfully excluded.
4848
*/
4949
static void DFSegmentation::CleanUnassociatedClusters(
5050
std::vector<std::shared_ptr<geometry::DFPointCloud>> &unassociatedClusters,
5151
std::vector<std::shared_ptr<geometry::DFPointCloud>> &existingPointCloudSegments,
52-
std::vector<std::vector<std::shared_ptr<geometry::DFMesh>>> Meshes,
52+
std::vector<std::vector<std::shared_ptr<geometry::DFMesh>>> meshes,
5353
double angleThreshold = 0.1,
5454
double associationThreshold = 0.1);
5555

56+
// FIXME: this one should go into DFMesh
5657
private: ///< helper methods
5758
/** @brief private method to check if a point is on a face of a triangle mesh triangle, within a certain association threshold. This takes into account the fact that, in 3D, a point can be "above" a triangle of a triangle mesh but still considered as being on the mesh face.
5859
* @param face the triangle mesh face to check the point against

0 commit comments

Comments
 (0)