FIX: mismatch in parameters for plugin code + conversion DFPointCloud colors from Rhino

Author: DamienGilliard

src/diffCheckBindings.cc

@@ -165,6 +165,6 @@ PYBIND11_MODULE(diffcheck_bindings, m) {
             py::arg("normal_threshold_degree") = 20,
             py::arg("min_cluster_size") = 10,
             py::arg("use_knn_neighborhood") = false,
-            py::arg("radius_neighborhood_size") = 10,
-            py::arg("knn_neighborhood_size") = 10);
+            py::arg("knn_neighborhood_size") = 10,
+            py::arg("radius_neighborhood_size") = 10);
 }

src/gh/components/DF_scan_segmentation/code.py

@@ -3,15 +3,16 @@
 import diffCheck.df_geometries as df_geo
 import diffCheck.diffcheck_bindings as df_bindings
 
-def main(model, voxel_size, normal_threshold, min_cluster_size, knn_neighborhood_size):
+def main(scan, voxel_size, normal_threshold, min_cluster_size, knn_neighborhood_size):
     a = []
     df_scan = df_cvt.cvt_rhcloud_2_dfcloud(scan)
-    res = df_bindings.dfb_segmentation.DFSegmentation.segmentation_point_cloud(df_scan, voxel_size, normal_threshold, min_cluster_size, false, 10, knn_neighborhood_size)
+    res = df_bindings.dfb_segmentation.DFSegmentation.segmentation_point_cloud(df_scan, voxel_size, normal_threshold, min_cluster_size, True, 10, knn_neighborhood_size)
     print(len(res))
     for pc in res:
-        a.append(pc)
+        rh_pc = df_cvt.cvt_dfcloud_2_rhcloud(pc)
+        a.append(rh_pc)
     return a
 
 if __name__ == "__main__":
-    a = main(model, voxel_size, normal_threshold, min_cluster_size, knn_neighborhood_size)
-    
+    a = main(scan, voxel_size, normal_threshold, min_cluster_size, knn)
+    pass

src/gh/diffCheck/diffCheck/df_cvt_bindings.py

@@ -35,7 +35,8 @@ def cvt_rhcloud_2_dfcloud(rh_cloud) -> diffcheck_bindings.dfb_geometry.DFPointCl
 
     # colors
     if rh_cloud.ContainsColors:
-        df_cloud.colors = [c for c in rh_cloud.GetColors()]
+        # df_cloud.colors = [c for c in rh_cloud.GetColors()]
+        df_cloud.colors = [[c.R, c.G, c.B] for c in rh_cloud.GetColors()]   
 
     return df_cloud