Merge pull request #32 from diffCheckOrg/ktree_impl

Removing signed distance for cloud-to-cloud

Author: mariklad

.vscode/settings.json

@@ -104,6 +104,7 @@
         "cwctype": "cpp",
         "memory_resource": "cpp",
         "scoped_allocator": "cpp",
-        "strstream": "cpp"
+        "strstream": "cpp",
+        "core": "cpp"
     }
 }

CMakeLists.txt

@@ -148,6 +148,7 @@ if (BUILD_PYTHON_MODULE)
         )
 
     # get all the files -dlls in the bin directory and copy them one by one to the pypi directory
+    message(STATUS "Copying dlls to ${TARGET_DLL_PYPI_DIR}")
     file(GLOB files ${CMAKE_BINARY_DIR}/bin/Release/*.dll)
     foreach(file ${files})
         message(STATUS "Copying ${file} to ${TARGET_DLL_PYPI_DIR}")

src/diffCheck/geometry/DFPointCloud.cc

@@ -120,16 +120,13 @@ namespace diffCheck::geometry
         this->Normals = cloud->Normals;
     }
 
-    std::vector<double> DFPointCloud::ComputeDistance(const diffCheck::geometry::DFPointCloud &targetCloud, bool useAbs)
+    std::vector<double> DFPointCloud::ComputeDistance(const diffCheck::geometry::DFPointCloud &targetCloud)
     {
         auto O3DSourcePointCloud = this->Cvt2O3DPointCloud();
         auto targetCloudCopy = targetCloud;
         auto O3DTargetPointCloud = targetCloudCopy.Cvt2O3DPointCloud();
         std::vector<double> distances;
         distances = O3DSourcePointCloud->ComputePointCloudDistance(*O3DTargetPointCloud);
-        if (useAbs)
-            for (auto &dist : distances)
-                dist = std::abs(dist);
         return distances;
     }
 }

src/diffCheck/geometry/DFPointCloud.hh

@@ -116,12 +116,11 @@ namespace diffCheck::geometry
          * It returns a vector of distances, one for each point in the source point cloud.
          * 
          * @param target the target point cloud in format df
-         * @param useAbs if true, the absolute value of the distance is returned
          * @return std::vector<double> the distance between the two point clouds
          * 
          * @see https://github.com/isl-org/Open3D/blob/main/cpp/open3d/geometry/PointCloud.cpp
          */
-        std::vector<double> ComputeDistance(const DFPointCloud &targetCloud, bool useAbs = true);
+        std::vector<double> ComputeDistance(const DFPointCloud &targetCloud);
 
     public:  ///< Getters
         /// @brief Number of points in the point cloud

src/diffCheckBindings.cc

@@ -30,8 +30,7 @@ PYBIND11_MODULE(diffcheck_bindings, m) {
         .def(py::init<std::vector<Eigen::Vector3d>, std::vector<Eigen::Vector3d>, std::vector<Eigen::Vector3d>>())
 
         .def("compute_distance", &diffCheck::geometry::DFPointCloud::ComputeDistance,
-            py::arg("target_cloud"),
-            py::arg("is_abs") = true)
+            py::arg("target_cloud"))
         .def("compute_BoundingBox", &diffCheck::geometry::DFPointCloud::ComputeBoundingBox)
 
         .def("voxel_downsample", &diffCheck::geometry::DFPointCloud::VoxelDownsample,