FIX: renaming of cilantro segmentation wrap following review

Author: DamienGilliard

src/diffCheck/segmentation/DFSegmentation.cc

@@ -6,7 +6,7 @@
 
 namespace diffCheck::segmentation
 {   
-    std::vector<std::shared_ptr<geometry::DFPointCloud>> DFSegmentation::SmoothSegmentation(
+    std::vector<std::shared_ptr<geometry::DFPointCloud>> DFSegmentation::NormalBasedSegmentation(
         geometry::DFPointCloud &pointCloud,
         float voxelSize,
         float normalThresholdDegree,

src/diffCheck/segmentation/DFSegmentation.hh

@@ -16,7 +16,7 @@ namespace diffCheck::segmentation
          * @param radiusNeighborhoodSize the radius of the neighborhood size for the "radius search". This is used when useKnnNeighborhood is false. A higher number will result in smoother segmentation, but at the cost of computation time.
          * @return std::vector<std::shared_ptr<geometry::DFPointCloud>> the segmented point clouds
          */
-        static std::vector<std::shared_ptr<geometry::DFPointCloud>> SmoothSegmentation(
+        static std::vector<std::shared_ptr<geometry::DFPointCloud>> NormalBasedSegmentation(
             geometry::DFPointCloud &pointCloud,
             float voxelSize = 0.2,
             float normalThresholdDegree = 20,

src/diffCheckApp.cc

@@ -15,7 +15,7 @@ int main()
   pcdSrc->LoadFromPLY(pathPcdSrc);
   meshSrc->LoadFromPLY(pathMeshSrc);
 
-  segments = diffCheck::segmentation::DFSegmentation::SmoothSegmentation(*pcdSrc, 0.01, 1, 30, true, 50, 30);
+  segments = diffCheck::segmentation::DFSegmentation::NormalBasedSegmentation(*pcdSrc, 0.01, 1, 30, true, 50, 30);
   std::cout << "number of segments:" << segments.size()<< std::endl;
 
   diffCheck::visualizer::Visualizer vis;

src/diffCheckBindings.cc

@@ -159,7 +159,7 @@ PYBIND11_MODULE(diffcheck_bindings, m) {
     py::module_ submodule_segmentation = m.def_submodule("dfb_segmentation", "A submodule for the `semantic` segmentation methods.");
 
     py::class_<diffCheck::segmentation::DFSegmentation>(submodule_segmentation, "DFSegmentation")
-        .def_static("smooth_segmentation", &diffCheck::segmentation::DFSegmentation::SmoothSegmentation,
+        .def_static("smooth_segmentation", &diffCheck::segmentation::DFSegmentation::NormalBasedSegmentation,
             py::arg("point_cloud"),
             py::arg("voxel_size") = 1,
             py::arg("normal_threshold_degree") = 20,