Skip to content

Commit 0d74df4

Browse files
FIX: segmentation parameters for segmentation test adapted for more robust results
1 parent 712c4b0 commit 0d74df4

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

tests/integration_tests/pybinds_tests/test_pybind_units.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,12 @@ def test_DFPlaneSegmentation():
300300
faces = [[0, 1, 2], [0, 2, 3], [0, 3, 4], [0, 4, 5]]
301301
mesh = dfb.dfb_geometry.DFMesh(vertices, faces, [], [], [])
302302
pc = mesh.sample_points_uniformly(1000)
303-
pc.estimate_normals(knn=200)
303+
pc.estimate_normals(knn=50)
304304

305-
segments = dfb.dfb_segmentation.DFSegmentation.segment_by_normal(pc, min_cluster_size=250)
305+
segments = dfb.dfb_segmentation.DFSegmentation.segment_by_normal(pc,
306+
normal_threshold_degree=10,
307+
min_cluster_size=200,
308+
knn_neighborhood_size=200)
306309

307310
assert len(segments) == 2, "DFPlaneSegmentation should return 2 segments"
308311

@@ -311,9 +314,12 @@ def test_DFPlaneSegmentation_disconnected_plans():
311314
faces = [[0, 1, 2], [3, 4, 5]]
312315
mesh = dfb.dfb_geometry.DFMesh(vertices, faces, [], [], [])
313316
pc = mesh.sample_points_uniformly(1000)
314-
pc.estimate_normals(knn=200)
317+
pc.estimate_normals(knn=50)
315318

316-
segments = dfb.dfb_segmentation.DFSegmentation.segment_by_normal(pc, min_cluster_size=250)
319+
segments = dfb.dfb_segmentation.DFSegmentation.segment_by_normal(pc,
320+
normal_threshold_degree=10,
321+
min_cluster_size=200,
322+
knn_neighborhood_size=200)
317323

318324
assert len(segments) == 2, "DFPlaneSegmentation should return 2 segments"
319325

0 commit comments

Comments
 (0)