Skip to content

Commit cac0624

Browse files
authored
fix: only add versionInTitle to new entry if it's not empty (#54)
1 parent 50f927b commit cac0624

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

actions/assemble-docs/dist/index.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19208,7 +19208,14 @@ async function upsertVersionsJson(params) {
1920819208
}
1920919209
versions[versionEntryIndex] = versionEntry;
1921019210
} else {
19211-
versions.push({ path: version2, label: versionLabel, versionInTitle });
19211+
const newVersionEntry = {
19212+
path: version2,
19213+
label: versionLabel
19214+
};
19215+
if (versionInTitle) {
19216+
newVersionEntry.versionInTitle = versionInTitle;
19217+
}
19218+
versions.push(newVersionEntry);
1921219219
}
1921319220
versions = versions.sort((a, b) => {
1921419221
if (a.path === LATEST_VERSION_NAME && b.path !== LATEST_VERSION_NAME) {

actions/assemble-docs/src/upsert-versions-json.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,14 @@ export async function upsertVersionsJson(params: {
2424
}
2525
versions[versionEntryIndex] = versionEntry;
2626
} else {
27-
versions.push({ path: version, label: versionLabel, versionInTitle });
27+
const newVersionEntry: VersionEntry = {
28+
path: version,
29+
label: versionLabel,
30+
};
31+
if (versionInTitle) {
32+
newVersionEntry.versionInTitle = versionInTitle;
33+
}
34+
versions.push(newVersionEntry);
2835
}
2936

3037
// Sort versions: latest first, then reverse alphabetically by path

0 commit comments

Comments
 (0)