Skip to content

Commit ed15792

Browse files
authored
Merge pull request #440 from vbakke/v4-patch-2
fix: Issues related to release of v4
2 parents 029e699 + fd37dd3 commit ed15792

File tree

4 files changed

+3907
-4645
lines changed

4 files changed

+3907
-4645
lines changed

src/app/app.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { TitleService } from './service/title.service';
1010
})
1111
export class AppComponent implements OnInit, OnDestroy {
1212
title = '';
13-
defaultTitle = 'DSOMM beta edition';
13+
defaultTitle = '';
1414
subtitle = '';
1515
menuIsOpen: boolean = true;
1616

src/app/model/activity-store.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { MarkdownText } from './markdown-text';
44

55
export class ActivityFileMeta {
66
static DSOMM_PUBLISHER: string =
7-
'https://github.com/devsecopsmaturitymodel/DevSecOps-MaturityModel-data/';
7+
'https://github.com/devsecopsmaturitymodel/DevSecOps-MaturityModel-data';
88

99
version: string | null = null;
1010
released: Date | null = null;
@@ -20,7 +20,7 @@ export class ActivityFileMeta {
2020

2121
getDsommVersion(): string | null {
2222
if (this.publisher && this.publisher.startsWith(ActivityFileMeta.DSOMM_PUBLISHER)) {
23-
return this.version;
23+
return this.version?.startsWith('v') ? this.version : `v${this.version}`;
2424
}
2525
return null;
2626
}

src/app/service/loader/data-loader.service.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class LoaderService {
4040
private githubService: GithubService,
4141
private notificationService: NotificationService
4242
) {
43-
this.DSOMM_MODEL_URL = this.githubService.getDsommModelUrl();
43+
this.DSOMM_MODEL_URL = this.githubService.getDsommModelUrl() + '/tree/main/generated';
4444
}
4545

4646
get datastore(): DataStore | null {
@@ -91,7 +91,11 @@ export class LoaderService {
9191
if (err instanceof FileNotFoundError) {
9292
console.error(`${perfNow()}: Missing model file: ${err?.filename || err}`);
9393
if (err.filename && err.filename.endsWith('default/model.yaml')) {
94-
this.notificationService.notify('Loading error', `No DSOMM model found.\n\nPlease download \`model.yaml\` from [GitHub](${this.DSOMM_MODEL_URL}).`); // eslint-disable-line
94+
let msg: string =
95+
`No DSOMM Model file found.\n\n` +
96+
`Please download \`model.yaml\` from [DSOMM-data](${this.DSOMM_MODEL_URL}) on GitHub, \\\n` +
97+
`and place it in the \`src\\assets\\default\` folder.`;
98+
this.notificationService.notify('Loading error', msg);
9599
} else {
96100
this.notificationService.notify('Loading error', err.message + ': ' + err.filename);
97101
}

0 commit comments

Comments
 (0)