Skip to content

Commit bc80abd

Browse files
authored
Merge pull request #72 from piyush140104/fix/remove-depreciated-dimensionsString-block
fix: remove redundant $dimensionsString block
2 parents aec524e + 14e0945 commit bc80abd

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

yaml-generation/generateDimensions.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,6 @@
163163
}
164164

165165

166-
// Post-process to add activity name as comment for `dependsOn`
167-
$dimensionsString = yaml_emit($dimensionsAggregated);
168-
preg_match_all('/\{!([0-9a-z-]{30,})!\}/', $dimensionsString, $matches);
169-
$uuids = array_unique($matches[1]);
170-
foreach ($uuids as $uuid) {
171-
$name = getActivityNameByUuid($uuid, $dimensionsAggregated);
172-
// echo "Adding dependsOn-comment for $uuid: $name\n";
173-
$dimensionsString = str_replace("'{!$uuid!}'", "$uuid # $name", $dimensionsString);
174-
}
175-
176166
// Store generated data with meta document first
177167
$metaDocument = array(
178168
'meta' => array(

0 commit comments

Comments
 (0)