More feedback added.

Author: janpgit

docs/class-assignments/extra-feedback.txt

@@ -2,6 +2,17 @@ Additional notes on the lab assignment based on existing implementations.
 
 Last updated: Dec 31, 2018.
 
+--------------------------------------------------------------------------------
+We really require you to use a consistent C style.
+
+For example, the following two lines do not use consistent C style as one line
+uses extra spaces with parentheses and the other does not, and also there is a
+differentce with whitespace around '{':
+
+if (WIFEXITED( wstatus )){
+
+if (pipe(pd) == -1) {
+
 --------------------------------------------------------------------------------
 Refuse special characters that you do not implement yet.  For example, if you do
 not implement pipes (as in the 1st phase), refuse it.  It cannot work like this:
@@ -17,11 +28,24 @@ If you did accept '|' as a normal character, it should have worked like this:
 $ echo hello | wc -l
 hello | wc -l
 
-However, please do something like this:
+And in case of date(1), it should have printed out an error, similar to this:
+
+$ date xxx
+date: illegal time format
+usage: date [-jnRu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
+            [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
+
+So, do something like the following:
 
 $ echo hello | wc -l
 (default rule matched) error:1: syntax error near unexpected token '|'
 
+Also, refure redirections unless you already implemented those.  The following
+is not correct in the 1st phase:
+
+$ echo hello > out
+hello
+
 --------------------------------------------------------------------------------
 Please do implement command line history.  In case of readline, it's really just
 calling one function, like this, for example: