Skip to content

Commit 6a3a99a

Browse files
author
Vladimir Kotal
committed
on spaghetti code
1 parent 37e79cd commit 6a3a99a

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

docs/class-assignments/extra-feedback.txt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,15 @@ if (WIFEXITED( wstatus )){
3333

3434
if (pipe(pd) == -1) {
3535

36+
--------------------------------------------------------------------------------
37+
Speaking of style, try to refactor as much as possible (while using function
38+
names easily readable by humans - and stick to consistent casing style).
39+
40+
When is function too long ? (so that it can be called "spaghetti code")
41+
If it spans multiple screens of wide screen terminal (let's say 80 lines
42+
printed in the font usually used in your environment for source code) it is
43+
probably time to do some refactoring.
44+
3645
--------------------------------------------------------------------------------
3746
Refuse special characters that you do not implement yet. For example, if you do
3847
not implement pipes (as in the 1st phase), refuse it. It cannot work like this:

0 commit comments

Comments
 (0)