Skip to content

Commit da1e25a

Browse files
committed
feat/node-view-allocated-res:
render: show “n/a” for negative requested CPU/memory values Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
1 parent 3bebdef commit da1e25a

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

internal/render/node_test.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@ import (
1616

1717
func TestNodeRender(t *testing.T) {
1818
pom := render.NodeWithMetrics{
19-
Raw: load(t, "no"),
20-
MX: makeNodeMX("n1", "10m", "20Mi"),
19+
Raw: load(t, "no"),
20+
MX: makeNodeMX("n1", "10m", "20Mi"),
21+
RequestedCPU: -1,
22+
RequestedMemory: -1,
2123
}
2224

2325
var no render.Node
@@ -26,8 +28,8 @@ func TestNodeRender(t *testing.T) {
2628
require.NoError(t, err)
2729

2830
assert.Equal(t, "minikube", r.ID)
29-
e := model1.Fields{"minikube", "Ready", "master", "amd64", "0", "v1.15.2", "Buildroot 2018.05.3", "4.15.0", "192.168.64.107", "<none>", "0", "10", "4000", "0", "20", "7874", "0", "n/a", "n/a"}
30-
assert.Equal(t, e, r.Fields[:19])
31+
e := model1.Fields{"minikube", "Ready", "master", "amd64", "0", "v1.15.2", "Buildroot 2018.05.3", "4.15.0", "192.168.64.107", "<none>", "0", "10", "4000", "n/a", "0", "n/a", "20", "7874", "n/a", "0", "n/a"}
32+
assert.Equal(t, e, r.Fields[:21])
3133
}
3234

3335
func BenchmarkNodeRender(b *testing.B) {

0 commit comments

Comments
 (0)