refactor(backend): simplify GitHub installation handling logic

Author: Lasim

package-lock.json

@@ -296,64 +296,13 @@ export default async function deployGitHubRoutes(server: FastifyInstance) {
     const { teamId } = request.params as { teamId: string };
 
     // Step 1: Check database for installation record
-    let installation = await credentialService.getInstallation(teamId, 'github');
+    const installation = await credentialService.getInstallation(teamId, 'github');
 
     if (!installation) {
-      // No database record - try to auto-detect and link
-      try {
-        const installations = await githubService.listInstallations();
-
-        if (installations.length > 0) {
-          // Found installations - select the best one (most recent, not suspended)
-          const selectedInstallation = installations[0];
-
-          // Auto-link to this team
-          await credentialService.storeInstallation({
-            teamId,
-            source: 'github',
-            installationId: selectedInstallation.id.toString()
-          });
-
-          server.log.info({
-            teamId,
-            installation_id: selectedInstallation.id,
-            account_login: selectedInstallation.account.login,
-            total_installations_found: installations.length,
-            operation: 'auto_linked_installation'
-          }, 'Auto-linked GitHub installation to team');
-
-          if (installations.length > 1) {
-            server.log.info({
-              teamId,
-              total_installations: installations.length,
-              selected_installation_id: selectedInstallation.id,
-              selected_account: selectedInstallation.account.login,
-              operation: 'multiple_installations_found'
-            }, 'Multiple GitHub installations found, selected most recent');
-          }
-
-          // Return connected
-          const response: ConnectionStatusResponse = { connected: true };
-          const jsonString = JSON.stringify(response);
-          return reply.status(200).type('application/json').send(jsonString);
-        }
-
-        // No installations found
-        server.log.info({
-          teamId,
-          operation: 'no_installations_found'
-        }, 'No GitHub installations found for user');
-
-        const response: ConnectionStatusResponse = { connected: false };
-        const jsonString = JSON.stringify(response);
-        return reply.status(200).type('application/json').send(jsonString);
-      } catch (error) {
-        // Failed to list installations - log and return false
-        server.log.warn({ error, teamId }, 'Failed to list GitHub installations during auto-detection');
-        const response: ConnectionStatusResponse = { connected: false };
-        const jsonString = JSON.stringify(response);
-        return reply.status(200).type('application/json').send(jsonString);
-      }
+      // No database record - team must install the GitHub App via the /install flow
+      const response: ConnectionStatusResponse = { connected: false };
+      const jsonString = JSON.stringify(response);
+      return reply.status(200).type('application/json').send(jsonString);
     }
 
     // Step 2: Verify installation still exists on GitHub
@@ -370,35 +319,7 @@ export default async function deployGitHubRoutes(server: FastifyInstance) {
           operation: 'stale_installation_cleaned'
         }, 'Cleaned up stale GitHub installation record');
 
-        // After cleaning up stale record, retry auto-detection
-        try {
-          const installations = await githubService.listInstallations();
-
-          if (installations.length > 0) {
-            const selectedInstallation = installations[0];
-
-            await credentialService.storeInstallation({
-              teamId,
-              source: 'github',
-              installationId: selectedInstallation.id.toString()
-            });
-
-            server.log.info({
-              teamId,
-              installation_id: selectedInstallation.id,
-              account_login: selectedInstallation.account.login,
-              total_installations_found: installations.length,
-              operation: 'auto_linked_installation_after_cleanup'
-            }, 'Auto-linked GitHub installation to team after cleaning stale record');
-
-            const response: ConnectionStatusResponse = { connected: true };
-            const jsonString = JSON.stringify(response);
-            return reply.status(200).type('application/json').send(jsonString);
-          }
-        } catch (retryError) {
-          server.log.warn({ error: retryError, teamId }, 'Failed to auto-detect installation after cleanup');
-        }
-
+        // Team must re-install the GitHub App via the /install flow
         const response: ConnectionStatusResponse = { connected: false };
         const jsonString = JSON.stringify(response);
         return reply.status(200).type('application/json').send(jsonString);

services/backend/src/routes/teams/deploy/github.ts

@@ -132,59 +132,6 @@ export class DeploymentGitHubService {
     }
   }
 
-  /**
-   * List all GitHub App installations accessible to this app
-   * Returns installations sorted by most recent (updated_at descending)
-   * Filters out suspended installations
-   */
-  async listInstallations(): Promise<Array<{
-    id: number;
-    account: {
-      login: string;
-      id: number;
-    };
-    created_at: string;
-    updated_at: string;
-    repository_selection: 'all' | 'selected';
-    suspended_at: string | null;
-  }>> {
-    try {
-      const config = await getGitHubAppConfig();
-
-      const appOctokit = new Octokit({
-        authStrategy: createAppAuth,
-        auth: {
-          appId: config.appId,
-          privateKey: config.privateKey
-        }
-      });
-
-      // Query GitHub API for all installations
-      const { data: installations } = await appOctokit.apps.listInstallations({
-        per_page: 100
-      });
-
-      // Filter out suspended installations and sort by most recent
-      return installations
-        .filter(installation => !installation.suspended_at)
-        .map(installation => ({
-          id: installation.id,
-          account: {
-            login: installation.account?.login || 'unknown',
-            id: installation.account?.id || 0
-          },
-          created_at: installation.created_at,
-          updated_at: installation.updated_at,
-          repository_selection: installation.repository_selection as 'all' | 'selected',
-          suspended_at: installation.suspended_at
-        }))
-        .sort((a, b) => new Date(b.updated_at).getTime() - new Date(a.updated_at).getTime());
-    } catch (error: unknown) {
-      const message = error instanceof Error ? error.message : 'Unknown error';
-      throw new Error(`Failed to list GitHub installations: ${message}`);
-    }
-  }
-
   /**
    * Get repository details
    */