Remove support for reading and writing encrypted strings in settings

Author: delphidabbler

Src/USettings.pas

@@ -119,19 +119,6 @@ interface
     ///  regardless of locale.</remarks>
     procedure SetDateTime(const Name: string; const Value: TDateTime);
 
-    ///  <summary>Gets a named encrypted string value from settings and
-    ///  unencrypts it.</summary>
-    ///  <param name="Name">string [in] Name of value.</param>
-    ///  <returns>string. The unencrypted string.</returns>
-    function GetEncryptedString(const Name: string): string;
-
-    ///  <summary>Encrypts and records a named string value in settings.
-    ///  </summary>
-    ///  <param name="Name">string [in] Name of value.</param>
-    ///  <param name="Value">string [in] Value to be encrypted and recored.
-    ///  </param>
-    procedure SetEncryptedString(const Name, Value: string);
-
     ///  <summary>Gets a list of related string values from the section.
     ///  </summary>
     ///  <param name="CountName">string [in] Name of an integer value that
@@ -234,7 +221,6 @@ implementation
   IOUtils,
   // Project
   UAppInfo,
-  UEncryptor,
   UHexUtils,
   UIOUtils,
   UStrUtils;
@@ -465,21 +451,6 @@   TIniSettingsSection = class(TIniSettingsBase, ISettingsSection)
     ///  </remarks>
     procedure SetDateTime(const Name: string; const Value: TDateTime);
 
-    ///  <summary>Gets a named encrypted string value from settings and
-    ///  unencrypts it.</summary>
-    ///  <param name="Name">string [in] Name of value.</param>
-    ///  <returns>string. The unencrypted string.</returns>
-    ///  <remarks>Method of ISettingsSection.</remarks>
-    function GetEncryptedString(const Name: string): string;
-
-    ///  <summary>Encrypts and records a named string value in settings.
-    ///  </summary>
-    ///  <param name="Name">string [in] Name of value.</param>
-    ///  <param name="Value">string [in] Value to be encrypted and recored.
-    ///  </param>
-    ///  <remarks>Method of ISettingsSection.</remarks>
-    procedure SetEncryptedString(const Name, Value: string);
-
     ///  <summary>Gets a list of related string values from the section.
     ///  </summary>
     ///  <param name="CountName">string [in] Name of an integer value that
@@ -608,17 +579,6 @@ destructor TIniSettingsSection.Destroy;
   inherited;
 end;
 
-function TIniSettingsSection.GetEncryptedString(const Name: string): string;
-var
-  EncryptedBytes: TBytes; // encrypted value as array of bytes
-begin
-  // NOTE:
-  // See SetEncryptedString for details of how encrypted values are stored.
-  if not TryHexToBytes(GetItemValue(Name), EncryptedBytes) then
-    Exit('');
-  Result := TEncoding.UTF8.GetString(TEncryptor.Decrypt(EncryptedBytes));
-end;
-
 function TIniSettingsSection.GetBoolean(const Name: string;
   const Default: Boolean): Boolean;
 var
@@ -746,19 +706,6 @@ procedure TIniSettingsSection.SetDateTime(const Name: string;
   SetItemValue(Name, FormatDateTime('yyyy"-"mm"-"dd" "hh":"nn":"ss', Value));
 end;
 
-procedure TIniSettingsSection.SetEncryptedString(const Name, Value: string);
-begin
-  // NOTE:
-  // Encrypted values are stored as follows:
-  // 1: Unicode Value string is converted to an array of UTF-8 encoded bytes
-  // 2: The UTF-8 byte array is encrypted into another array of bytes
-  // 3: The encrypted byte array is converted to hexadecimal
-  // 4: The hexadecimal character string is stored in storage
-  SetItemValue(
-    Name, BytesToHex(TEncryptor.Encrypt(TEncoding.UTF8.GetBytes(Value)))
-  );
-end;
-
 procedure TIniSettingsSection.SetFloat(const Name: string; const Value: Double);
 begin
   SetItemValue(Name, FloatToStr(Value));