Skip to content

Commit 9264447

Browse files
committed
fix: Flaky test by not patching time.sleep
1 parent f8b8dfa commit 9264447

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

tests/unit/test_deepnote_toolkit_cli.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ def test_process_cleanup_on_interrupt(
235235
# Mock the process manager
236236
mock_manager = mock.MagicMock()
237237
mock_manager.processes = [mock_proc1, mock_proc2]
238-
mock_manager.check_processes.return_value = []
238+
mock_manager.check_processes.side_effect = KeyboardInterrupt
239239
mock_context.return_value.__enter__.return_value = mock_manager
240240

241241
args = argparse.Namespace(
@@ -247,13 +247,7 @@ def test_process_cleanup_on_interrupt(
247247
python_kernel_only=None,
248248
)
249249

250-
# Simulate interrupt after process checks
251-
# Need to mock: 2x time.sleep(0.1) for process checks, then 1x time.sleep(1) before interrupt
252-
with mock.patch(
253-
"deepnote_toolkit.cli.server.time.sleep",
254-
side_effect=[None, None, None, KeyboardInterrupt],
255-
):
256-
ret = run_server_command(args)
250+
ret = run_server_command(args)
257251

258252
assert ret == 0
259253

@@ -265,7 +259,7 @@ def test_process_cleanup_on_interrupt(
265259
mock_manager.add_process.assert_any_call(mock_proc1)
266260
mock_manager.add_process.assert_any_call(mock_proc2)
267261

268-
# Verify monitoring occurred
262+
# Verify monitoring was attempted (interrupt occurred during check)
269263
mock_manager.check_processes.assert_called()
270264

271265

0 commit comments

Comments
 (0)