Tests: Use assertSame() in wp_count_posts() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [1323/tests], [25554], [27081], [60788].

Props costdev, SergeyBiryukov.
See #64324.

git-svn-id: https://develop.svn.wordpress.org/trunk@61417 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

tests/phpunit/tests/post.php

@@ -183,7 +183,7 @@ public function test_wp_count_posts() {
 		);
 
 		$count = wp_count_posts( $post_type, 'readable' );
-		$this->assertEquals( 1, $count->publish );
+		$this->assertSame( '1', $count->publish );
 
 		_unregister_post_type( $post_type );
 		$count = wp_count_posts( $post_type, 'readable' );
@@ -226,7 +226,7 @@ public function test_wp_count_posts_readable_excludes_unreadable_private_posts()
 		wp_set_current_user( self::$user_ids['author'] );
 
 		$count = wp_count_posts( $post_type, 'readable' );
-		$this->assertEquals( 5, $count->publish );
+		$this->assertSame( '5', $count->publish );
 		_unregister_post_type( $post_type );
 	}
 
@@ -245,16 +245,16 @@ public function test_wp_count_posts_filtered() {
 		);
 
 		$count1 = wp_count_posts( $post_type, 'readable' );
-		$this->assertEquals( 3, $count1->publish );
+		$this->assertSame( '3', $count1->publish );
 
 		add_filter( 'wp_count_posts', array( $this, 'filter_wp_count_posts' ) );
 		$count2 = wp_count_posts( $post_type, 'readable' );
 		remove_filter( 'wp_count_posts', array( $this, 'filter_wp_count_posts' ) );
-		$this->assertEquals( 2, $count2->publish );
+		$this->assertSame( '2', $count2->publish );
 	}
 
 	public function filter_wp_count_posts( $counts ) {
-		$counts->publish = 2;
+		$counts->publish = '2';
 		return $counts;
 	}
 
@@ -276,8 +276,8 @@ public function test_wp_count_posts_insert_invalidation() {
 		$this->assertNotEquals( 'publish', $post->post_status );
 
 		$after_draft_counts = wp_count_posts();
-		$this->assertEquals( 1, $after_draft_counts->draft );
-		$this->assertEquals( 2, $after_draft_counts->publish );
+		$this->assertSame( '1', $after_draft_counts->draft );
+		$this->assertSame( '2', $after_draft_counts->publish );
 		$this->assertNotEquals( $initial_counts->publish, $after_draft_counts->publish );
 	}
 
@@ -297,8 +297,8 @@ public function test_wp_count_posts_trash_invalidation() {
 		$this->assertNotEquals( 'publish', $post->post_status );
 
 		$after_trash_counts = wp_count_posts();
-		$this->assertEquals( 1, $after_trash_counts->trash );
-		$this->assertEquals( 2, $after_trash_counts->publish );
+		$this->assertSame( '1', $after_trash_counts->trash );
+		$this->assertSame( '2', $after_trash_counts->publish );
 		$this->assertNotEquals( $initial_counts->publish, $after_trash_counts->publish );
 	}