Reduce for property complexity

Author: davidwalschots

angular-reactive-validation/src/validation-messages/validation-messages.component.ts

@@ -47,24 +47,17 @@ export class ValidationMessagesComponent implements AfterContentInit, OnDestroy
 
   @Input()
   set for(controls: FormControl | (FormControl|string)[] | string) {
-    if (Array.isArray(controls)) {
-      if (controls.length === 0) {
-        throw new Error(`arv-validation-messages doesn't allow declaring an empty array as input to the 'for' attribute.`);
-      }
+    if (!Array.isArray(controls)) {
+      controls = controls !== undefined ? [controls] : [];
+    }
 
-      this._for = controls.map(control => {
-        if (typeof control === 'string') {
-          return getFormControlFromContainer(control, this.controlContainer);
-        } else {
-          return control;
-        }
-      });
-    } else if (typeof controls === 'string') {
-      this._for = [getFormControlFromContainer(controls, this.controlContainer)];
-    } else {
-      this._for = [controls];
+    if (controls.length === 0) {
+      throw new Error(`arv-validation-messages doesn't allow declaring an empty array as input to the 'for' attribute.`);
     }
 
+    this._for = controls.map(control => typeof control === 'string' ?
+      getFormControlFromContainer(control, this.controlContainer) : control);
+
     this.validateChildren();
     this.controlStatusChangesContainer.unsubscribeAll();
     this.controlStatusChangesContainer.subscribe(this._for, control => control.statusChanges, true);