Skip to content

Commit b6cf20f

Browse files
test: Remove xfail markers for describe() tests now that nullable is preserved
The describe() method now correctly preserves nullable modifiers on FK attributes, so these tests should pass. Removed xfail from: - test_declare.py::test_describe - test_declare.py::test_describe_indexes - test_declare.py::test_describe_dependencies - test_foreign_keys.py::test_describe Note: test_json.py::test_describe still has xfail for a separate issue (index reconstruction). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent ad127be commit b6cf20f

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

tests/integration/test_declare.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ def test_instance_help(schema_any):
4040
assert TTest2().definition in TTest2().__doc__
4141

4242

43-
@pytest.mark.xfail(reason="describe() doesn't preserve NOT NULL on FK attributes - pre-existing bug")
4443
def test_describe(schema_any):
4544
"""real_definition should match original definition"""
4645
rel = Experiment()
@@ -51,7 +50,6 @@ def test_describe(schema_any):
5150
assert s1[0] == s2[0] # Compare SQL only (declare now returns tuple)
5251

5352

54-
@pytest.mark.xfail(reason="describe() doesn't preserve NOT NULL on FK attributes - pre-existing bug")
5553
def test_describe_indexes(schema_any):
5654
"""real_definition should match original definition"""
5755
rel = IndexRich()
@@ -62,7 +60,6 @@ def test_describe_indexes(schema_any):
6260
assert s1[0] == s2[0] # Compare SQL only (declare now returns tuple)
6361

6462

65-
@pytest.mark.xfail(reason="describe() doesn't preserve NOT NULL on FK attributes - pre-existing bug")
6663
def test_describe_dependencies(schema_any):
6764
"""real_definition should match original definition"""
6865
rel = ThingC()

tests/integration/test_foreign_keys.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import pytest
2-
31
from datajoint.declare import declare
42

53
from tests.schema_advanced import (
@@ -29,7 +27,6 @@ def test_aliased_fk(schema_adv):
2927
assert delete_count == 16
3028

3129

32-
@pytest.mark.xfail(reason="describe() doesn't preserve NOT NULL on FK attributes - pre-existing bug")
3330
def test_describe(schema_adv):
3431
"""real_definition should match original definition"""
3532
for rel in (LocalSynapse, GlobalSynapse):

0 commit comments

Comments
 (0)