Skip to content

Commit 12bfd5b

Browse files
Fix float inference to use DoubleParameter (64-bit) instead of FloatP… (#742)
* Fix float inference to use DoubleParameter (64-bit) instead of FloatParameter (32-bit) Signed-off-by: Shubhambhusate <bhusates6@gmail.com> * Add DoubleParameter with Primitive.DOUBLE to test_inference coverage --------- Signed-off-by: Shubhambhusate <bhusates6@gmail.com>
1 parent e916f71 commit 12bfd5b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/databricks/sql/parameters/native.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,7 @@ def dbsql_parameter_from_primitive(
659659
elif isinstance(value, str):
660660
return StringParameter(value=value, name=name)
661661
elif isinstance(value, float):
662-
return FloatParameter(value=value, name=name)
662+
return DoubleParameter(value=value, name=name)
663663
elif isinstance(value, datetime.datetime):
664664
return TimestampParameter(value=value, name=name)
665665
elif isinstance(value, datetime.date):

tests/unit/test_parameters.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,8 @@ def test_tspark_param_ordinal(self):
295295
(BigIntegerParameter, Primitive.BIGINT),
296296
(BooleanParameter, Primitive.BOOL),
297297
(DateParameter, Primitive.DATE),
298-
(FloatParameter, Primitive.FLOAT),
298+
(DoubleParameter, Primitive.DOUBLE),
299+
(DoubleParameter, Primitive.FLOAT),
299300
(VoidParameter, Primitive.NONE),
300301
(TimestampParameter, Primitive.TIMESTAMP),
301302
(MapParameter, Primitive.MAP),
@@ -305,7 +306,7 @@ def test_tspark_param_ordinal(self):
305306
def test_inference(self, _type: TDbsqlParameter, prim: Primitive):
306307
"""This method only tests inferrable types.
307308
308-
Not tested are TinyIntParameter, SmallIntParameter DoubleParameter and TimestampNTZParameter
309+
Not tested are TinyIntParameter, SmallIntParameter, FloatParameter and TimestampNTZParameter
309310
"""
310311

311312
inferred_type = dbsql_parameter_from_primitive(prim.value)

0 commit comments

Comments
 (0)