Skip to content

Commit e3499a8

Browse files
committed
Merge branch 'main' into emmyzhou-db/async_token_cache_wrapper
2 parents 8970e1b + 580c015 commit e3499a8

File tree

6 files changed

+28
-19
lines changed

6 files changed

+28
-19
lines changed

databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/Token.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public String getAccessToken() {
7070
}
7171

7272
/**
73-
* Returns the expiry time of the token as a LocalDateTime.
73+
* Returns the expiry time of the token as a Instant.
7474
*
7575
* @return the expiry time
7676
*/

databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/DataPlaneTokenSourceTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ void testDataPlaneTokenSource(
194194
assertEquals(expectedToken.getAccessToken(), token.getAccessToken());
195195
assertEquals(expectedToken.getTokenType(), token.getTokenType());
196196
assertEquals(expectedToken.getRefreshToken(), token.getRefreshToken());
197+
assertTrue(expectedToken.getExpiry().isAfter(Instant.now()));
197198
}
198199
}
199200

databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/FileTokenCacheTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ void testSaveAndLoadToken() {
5454
assertEquals("access-token", loadedToken.getAccessToken());
5555
assertEquals("Bearer", loadedToken.getTokenType());
5656
assertEquals("refresh-token", loadedToken.getRefreshToken());
57+
assertEquals(expiry, loadedToken.getExpiry());
5758
}
5859

5960
@Test

databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/TokenTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ void createNonRefreshableToken() {
1818
assertEquals(accessToken, token.getAccessToken());
1919
assertEquals(tokenType, token.getTokenType());
2020
assertNull(token.getRefreshToken());
21+
assertEquals(currentInstant.plusSeconds(300), token.getExpiry());
2122
}
2223

2324
@Test
@@ -26,5 +27,6 @@ void createRefreshableToken() {
2627
assertEquals(accessToken, token.getAccessToken());
2728
assertEquals(tokenType, token.getTokenType());
2829
assertEquals(refreshToken, token.getRefreshToken());
30+
assertEquals(currentInstant.plusSeconds(300), token.getExpiry());
2931
}
3032
}

databricks-sdk-java/src/test/java/com/databricks/sdk/core/utils/FakeClockSupplier.java

Lines changed: 0 additions & 18 deletions
This file was deleted.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
package com.databricks.sdk.core.utils;
2+
3+
import java.time.Clock;
4+
import java.time.Duration;
5+
import java.time.Instant;
6+
import java.time.ZoneId;
7+
8+
public class TestClockSupplier implements ClockSupplier {
9+
private Clock clock;
10+
11+
public TestClockSupplier(Instant fixedInstant) {
12+
clock = Clock.fixed(fixedInstant, ZoneId.of("UTC"));
13+
}
14+
15+
public void advanceTime(Duration duration) {
16+
clock = Clock.offset(clock, duration);
17+
}
18+
19+
@Override
20+
public Clock getClock() {
21+
return clock;
22+
}
23+
}

0 commit comments

Comments
 (0)