reverted to Clang 21 for now

The LLVM 22 repo from apt.llvm.org is currently broken and the packages were also out-of-date

Author: firewave

.clang-tidy

@@ -22,8 +22,6 @@ Checks: >
         -bugprone-easily-swappable-parameters,
         -bugprone-narrowing-conversions,
         -bugprone-switch-missing-default-case,
-        -bugprone-throwing-static-initialization,
-        -bugprone-unchecked-string-to-number-conversion,
         -concurrency-mt-unsafe,
         -misc-no-recursion,
         -misc-non-private-member-variables-in-classes,

.github/workflows/clang-tidy.yml

@@ -33,19 +33,19 @@ jobs:
         run: |
           wget https://apt.llvm.org/llvm.sh
           chmod +x llvm.sh
-          sudo ./llvm.sh 22
-          sudo apt-get install clang-tidy-22
+          sudo ./llvm.sh 21
+          sudo apt-get install clang-tidy-21
 
       - name: Verify clang-tidy configuration
         run: |
-          clang-tidy-22 --verify-config
+          clang-tidy-21 --verify-config
 
       - name: Prepare CMake
         run: |
           cmake -S . -B cmake.output -Werror=dev --warn-uninitialized -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
         env:
-          CXX: clang-22
+          CXX: clang-21
 
       - name: Clang-Tidy
         run: |
-          run-clang-tidy-22 -q -j $(nproc) -enable-check-profile -p=cmake.output
+          run-clang-tidy-21 -q -j $(nproc) -enable-check-profile -p=cmake.output