From b750a910e69515d612263b0a33fb61116ea293c8 Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Fri, 20 Feb 2026 10:02:42 +0100 Subject: [PATCH 1/2] Skip performance tests on Mac CI for now, since they're flaky there --- .../src/suite/performance.vscode.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts b/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts index 806f34864f..25ce6e7bd5 100644 --- a/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts +++ b/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts @@ -22,6 +22,11 @@ const thresholds = [smallThresholdMs, largeThresholdMs, xlThresholdMs]; type ModifierType = "containing" | "previous" | "every"; suite(`Performance ${thresholds.join("/")} ms`, async function () { + // FIXME: This test is flaky on Mac CI, so we skip it there for now + if (isCI() && isMac()) { + this.ctx.skip(); + } + endToEndTestSetup(this); let previousTitle = ""; @@ -261,13 +266,8 @@ function generateTestData(n: number): string { function calculateMultiplier() { // The GitHub test runner is generally slower than running tests locally, so - // we increase the thresholds in CI. We do this for all platforms, but - // especially for macOS since the GitHub test runner for macOS is particularly - // slow. + // we increase the thresholds in CI. if (isCI()) { - if (isMac()) { - return 3; - } return 2; } return 1; From afb304c59eee321c5fdb01c749318ea63dd0daaf Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Fri, 20 Feb 2026 13:25:58 +0100 Subject: [PATCH 2/2] Doc skip in before each --- .../src/suite/performance.vscode.test.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts b/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts index 25ce6e7bd5..1d8f43dcb3 100644 --- a/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts +++ b/packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts @@ -22,11 +22,6 @@ const thresholds = [smallThresholdMs, largeThresholdMs, xlThresholdMs]; type ModifierType = "containing" | "previous" | "every"; suite(`Performance ${thresholds.join("/")} ms`, async function () { - // FIXME: This test is flaky on Mac CI, so we skip it there for now - if (isCI() && isMac()) { - this.ctx.skip(); - } - endToEndTestSetup(this); let previousTitle = ""; @@ -34,6 +29,12 @@ suite(`Performance ${thresholds.join("/")} ms`, async function () { // Before each test, print the test title. This is done so we have the test // title before the test run time / duration. this.beforeEach(function () { + // FIXME: This test is flaky on Mac CI, so we skip it there for now + if (isCI() && isMac()) { + this.skip(); + return; + } + const title = this.currentTest!.title; if (title !== previousTitle) { console.log(` ${title}`);