Handle SecretStr for password in UserCredential methods

Author: gabino

cuenca/resources/user_credentials.py

@@ -5,6 +5,7 @@
     UserCredentialRequest,
     UserCredentialUpdateRequest,
 )
+from pydantic import SecretStr
 
 from ..http import Session, session as global_session
 from .base import Creatable, Updateable
@@ -25,7 +26,10 @@ def create(
         session: Session = global_session,
     ) -> 'UserCredential':
         req = UserCredentialRequest(password=password, user_id=user_id)
-        return cls._create(**req.model_dump(), session=session)
+        data = req.model_dump()
+        if isinstance(data['password'], SecretStr):
+            data['password'] = data['password'].get_secret_value()
+        return cls._create(**data, session=session)
 
     @classmethod
     def update(
@@ -40,4 +44,7 @@ def update(
             is_active=is_active,
             password=password,
         )
-        return cls._update(id=user_id, **req.model_dump(), session=session)
+        data = req.model_dump()
+        if password and isinstance(data['password'], SecretStr):
+            data['password'] = data['password'].get_secret_value()
+        return cls._update(id=user_id, **data, session=session)

tests/resources/cassettes/test_update_password.yaml

@@ -1,6 +1,6 @@
 interactions:
 - request:
-    body: '{"password": "222222"}'
+    body: '{"password": "22222222"}'
     headers:
       Accept:
       - '*/*'
@@ -54,7 +54,7 @@ interactions:
       code: 201
       message: Created
 - request:
-    body: '{"password": "222222"}'
+    body: '{"password": "22222222"}'
     headers:
       Accept:
       - '*/*'
@@ -108,7 +108,7 @@ interactions:
       code: 201
       message: Created
 - request:
-    body: '{"is_active": null, "password": "111111"}'
+    body: '{"is_active": null, "password": "11111111"}'
     headers:
       Accept:
       - '*/*'

tests/resources/test_user_credentials.py

@@ -7,9 +7,9 @@
 
 @pytest.mark.vcr
 def test_update_password():
-    UserCredential.create('222222')
-    UserLogin.create('222222')
-    UserCredential.update(password='111111')
+    UserCredential.create('22222222')
+    UserLogin.create('22222222')
+    UserCredential.update(password='11111111')
 
 
 @pytest.mark.vcr