Adding dynamic cvv to card (#302)

* adding dcvv fields

* fixing

* bump cv

* lint

* fix

* version

* version

* comments

Author: chiqeen03

cuenca/resources/cards.py

@@ -1,3 +1,4 @@
+import datetime as dt
 from typing import ClassVar, Optional, cast
 
 from cuenca_validations.types import (
@@ -30,9 +31,12 @@ class Card(Retrievable, Queryable, Creatable, Updateable):
     status: CardStatus
     issuer: CardIssuer
     funding_type: CardFundingType
+    dcvv: Optional[str] = None
+    dcvv_expires_at: Optional[dt.datetime] = None
     pin_attempts_failed: Optional[int] = None
     platform_id: Optional[str] = None
     card_holder_user_id: Optional[str] = None
+    is_dynamic_cvv: bool = False
 
     @property
     def last_4_digits(self):
@@ -57,6 +61,7 @@ def create(
         funding_type: CardFundingType,
         user_id: str = 'me',
         card_holder_user_id: Optional[str] = None,
+        is_dynamic_cvv: bool = False,
         *,
         session: Session = global_session,
     ) -> 'Card':
@@ -74,6 +79,7 @@ def create(
             issuer=issuer,
             funding_type=funding_type,
             card_holder_user_id=card_holder_user_id,
+            is_dynamic_cvv=is_dynamic_cvv,
         )
         return cast('Card', cls._create(session=session, **req.dict()))
 
@@ -83,6 +89,7 @@ def update(
         card_id: str,
         status: Optional[CardStatus] = None,
         pin_block: Optional[str] = None,
+        is_dynamic_cvv: bool = False,
         *,
         session: Session = global_session,
     ) -> 'Card':
@@ -96,7 +103,9 @@ def update(
         :param session:
         :return: Updated card object
         """
-        req = CardUpdateRequest(status=status, pin_block=pin_block)
+        req = CardUpdateRequest(
+            status=status, pin_block=pin_block, is_dynamic_cvv=is_dynamic_cvv
+        )
         resp = cls._update(card_id, session=session, **req.dict())
         return cast('Card', resp)
 

cuenca/version.py

@@ -1,3 +1,3 @@
-__version__ = '0.14.6'
+__version__ = '0.15.0'
 CLIENT_VERSION = __version__
 API_VERSION = '2020-03-19'

requirements.txt

@@ -1,3 +1,3 @@
 requests==2.27.1
-cuenca-validations==0.11.4
+cuenca-validations==0.11.5
 dataclasses>=0.7;python_version<"3.7"

tests/resources/cassettes/test_card_create.yaml

@@ -1,6 +1,7 @@
 interactions:
 - request:
-    body: '{"user_id": "US1237", "issuer": "cuenca", "funding_type": "credit"}'
+    body: '{"user_id": "US1237", "issuer": "cuenca", "funding_type":
+      "credit", "is_dynamic_cvv": false}'
     headers:
       Accept:
       - '*/*'
@@ -11,43 +12,41 @@ interactions:
       Connection:
       - keep-alive
       Content-Length:
-      - '67'
+      - '110'
       Content-Type:
       - application/json
       User-Agent:
-      - cuenca-python/0.6.3.dev2
+      - cuenca-python/0.15.0
       X-Cuenca-Api-Version:
       - '2020-03-19'
     method: POST
     uri: https://sandbox.cuenca.com/cards
   response:
     body:
-      string: '{"id":"CAycvo_X9TQoKOKsaAvdqn3w","created_at":"2021-02-21T16:03:37.590964","updated_at":"2021-02-21T16:03:37.590972","user_id":"US1237","number":"5448750078699849","exp_month":2,"exp_year":2026,"cvv2":"353","type":"virtual","status":"active","batch":null,"manufacturer":null,"cvv":null,"icvv":null,"pin":null,"issuer":"cuenca","funding_type":"debit","_cls":"BaseCard.CuencaCard"}'
+      string: '{"id":"CAvrnMlojFRLuMyPPveULAoA","created_at":"2022-09-27T22:32:34.616733","updated_at":"2022-09-27T22:32:35.129133","user_id":"US1237","platform_id":"PTCHzhZ0ILRN-oxwd0u2coiQ","number":"5448750030324585","exp_month":9,"exp_year":27,"cvv2":"783","type":"virtual","status":"active","pin":null,"issuer":"cuenca","funding_type":"credit","card_holder_user_id":"US118qfWNLSaOaDSPxbPzdIg","manufacturer":null,"cvv":"540","icvv":null,"is_dynamic_cvv":false,"pin_block":null,"pin_block_switch":null,"pin_attempts_failed":0}'
     headers:
       Connection:
       - keep-alive
       Content-Length:
-      - '379'
+      - '533'
       Content-Type:
       - application/json
       Date:
-      - Sun, 21 Feb 2021 16:03:40 GMT
-      X-Amzn-Trace-Id:
-      - Root=1-60328452-3d9fd97d6169e99371e444b7;Sampled=0
+      - Tue, 27 Sep 2022 22:32:35 GMT
+      X-Request-Time:
+      - 'value: 0.870'
       x-amz-apigw-id:
-      - bGmc6EwFCYcFueQ=
+      - ZJAAaEt7CYcFcyA=
       x-amzn-Remapped-Connection:
       - keep-alive
       x-amzn-Remapped-Content-Length:
-      - '379'
+      - '533'
       x-amzn-Remapped-Date:
-      - Sun, 21 Feb 2021 16:03:40 GMT
+      - Tue, 27 Sep 2022 22:32:35 GMT
       x-amzn-Remapped-Server:
-      - nginx/1.18.0
-      x-amzn-Remapped-x-amzn-RequestId:
-      - 6e42147f-60fc-420a-aea2-5896717f36b1
+      - nginx/1.22.0
       x-amzn-RequestId:
-      - 3e8b6d93-7d77-40b6-95be-e4b7c9a1fc57
+      - f6dfb169-9440-4b5a-b2ae-267e87945de7
     status:
       code: 201
       message: Created

tests/resources/cassettes/test_card_create_dcvv.yaml

@@ -0,0 +1,53 @@
+interactions:
+- request:
+    body: '{"user_id": "US1237", "issuer": "cuenca", "funding_type":
+      "credit", "is_dynamic_cvv": true}'
+    headers:
+      Accept:
+      - '*/*'
+      Accept-Encoding:
+      - gzip, deflate
+      Authorization:
+      - DUMMY
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '109'
+      Content-Type:
+      - application/json
+      User-Agent:
+      - cuenca-python/0.15.0
+      X-Cuenca-Api-Version:
+      - '2020-03-19'
+    method: POST
+    uri: https://sandbox.cuenca.com/cards
+  response:
+    body:
+      string: '{"id":"CAXhjbtkPtR0mK4mB-qxAfTg","created_at":"2022-09-27T22:40:32.407778","updated_at":"2022-09-27T22:40:32.924951","user_id":"US1237","platform_id":"PTCHzhZ0ILRN-oxwd0u2coiQ","number":"5448750085957396","exp_month":9,"exp_year":27,"cvv2":"847","type":"virtual","status":"active","pin":null,"issuer":"cuenca","funding_type":"credit","card_holder_user_id":"US118qfWNLSaOaDSPxbPzdIg","manufacturer":null,"cvv":"323","icvv":null,"is_dynamic_cvv":true,"pin_block":null,"pin_block_switch":null,"pin_attempts_failed":0}'
+    headers:
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '532'
+      Content-Type:
+      - application/json
+      Date:
+      - Tue, 27 Sep 2022 22:40:33 GMT
+      X-Request-Time:
+      - 'value: 0.953'
+      x-amz-apigw-id:
+      - ZJBLEF_5CYcFSBA=
+      x-amzn-Remapped-Connection:
+      - keep-alive
+      x-amzn-Remapped-Content-Length:
+      - '532'
+      x-amzn-Remapped-Date:
+      - Tue, 27 Sep 2022 22:40:33 GMT
+      x-amzn-Remapped-Server:
+      - nginx/1.22.0
+      x-amzn-RequestId:
+      - b1364573-21c6-4c12-bcf7-fb294c66012e
+    status:
+      code: 201
+      message: Created
+version: 1

tests/resources/cassettes/test_card_retrieve.yaml

@@ -11,39 +11,37 @@ interactions:
       Connection:
       - keep-alive
       User-Agent:
-      - cuenca-python/0.6.3.dev2
+      - cuenca-python/0.15.0
       X-Cuenca-Api-Version:
       - '2020-03-19'
     method: GET
     uri: https://sandbox.cuenca.com/cards/CAycvo_X9TQoKOKsaAvdqn3w
   response:
     body:
-      string: '{"id":"CAycvo_X9TQoKOKsaAvdqn3w","created_at":"2021-02-21T16:03:37.590000","updated_at":"2021-02-21T16:03:37.590000","user_id":"US1237","number":"5448750078699849","exp_month":2,"exp_year":2026,"cvv2":"353","type":"virtual","status":"active","batch":null,"manufacturer":null,"cvv":null,"icvv":null,"pin":null,"issuer":"cuenca","funding_type":"debit","_cls":"BaseCard.CuencaCard"}'
+      string: '{"id":"CAycvo_X9TQoKOKsaAvdqn3w","created_at":"2022-09-27T22:49:23.404000","updated_at":"2022-09-27T22:49:23.907000","user_id":"US118qfWNLSaOaDSPxbPzdIg","platform_id":"PTCHzhZ0ILRN-oxwd0u2coiQ","number":"5448750051287265","exp_month":9,"exp_year":27,"cvv2":"657","type":"virtual","status":"active","pin":null,"issuer":"cuenca","funding_type":"credit","card_holder_user_id":"US118qfWNLSaOaDSPxbPzdIg","manufacturer":null,"cvv":"100","icvv":null,"is_dynamic_cvv":false,"pin_block":null,"pin_block_switch":null,"pin_attempts_failed":0}'
     headers:
       Connection:
       - keep-alive
       Content-Length:
-      - '379'
+      - '533'
       Content-Type:
       - application/json
       Date:
-      - Mon, 22 Feb 2021 22:06:23 GMT
-      X-Amzn-Trace-Id:
-      - Root=1-60342ade-474422113c7c4e36041bd343;Sampled=0
+      - Tue, 27 Sep 2022 22:49:54 GMT
+      X-Request-Time:
+      - 'value: 0.507'
       x-amz-apigw-id:
-      - bKuixEr3iYcFQ3w=
+      - ZJCi2GpqCYcFT5Q=
       x-amzn-Remapped-Connection:
       - keep-alive
       x-amzn-Remapped-Content-Length:
-      - '379'
+      - '533'
       x-amzn-Remapped-Date:
-      - Mon, 22 Feb 2021 22:06:23 GMT
+      - Tue, 27 Sep 2022 22:49:54 GMT
       x-amzn-Remapped-Server:
-      - nginx/1.18.0
-      x-amzn-Remapped-x-amzn-RequestId:
-      - 23a73914-2022-4a0f-970e-ce7321d26c1a
+      - nginx/1.22.0
       x-amzn-RequestId:
-      - 5d785911-f1b1-4b9a-954c-8aabf89ac457
+      - 17b3414e-88e4-41d6-8d3e-358a6cd6fd48
     status:
       code: 200
       message: OK

tests/resources/cassettes/test_card_retrieve_dcvv.yaml

@@ -0,0 +1,48 @@
+interactions:
+- request:
+    body: null
+    headers:
+      Accept:
+      - '*/*'
+      Accept-Encoding:
+      - gzip, deflate
+      Authorization:
+      - DUMMY
+      Connection:
+      - keep-alive
+      User-Agent:
+      - cuenca-python/0.15.0
+      X-Cuenca-Api-Version:
+      - '2020-03-19'
+    method: GET
+    uri: https://sandbox.cuenca.com/cards/CAycvo_X9TQoKOKsaAvdqn3w
+  response:
+    body:
+      string: '{"id":"CAycvo_X9TQoKOKsaAvdqn3w","created_at":"2022-09-27T22:49:23.404000","updated_at":"2022-09-27T22:51:24.249000","user_id":"US118qfWNLSaOaDSPxbPzdIg","platform_id":"PTCHzhZ0ILRN-oxwd0u2coiQ","number":"5448750051287265","exp_month":9,"exp_year":27,"cvv2":"657","type":"virtual","status":"active","pin":null,"issuer":"cuenca","funding_type":"credit","card_holder_user_id":"US118qfWNLSaOaDSPxbPzdIg","manufacturer":null,"cvv":"100","icvv":null,"is_dynamic_cvv":true,"pin_block":null,"pin_block_switch":null,"pin_attempts_failed":0,"dcvv":"829","dcvv_expires_at":"2022-09-27T22:59:10.066677"}'
+    headers:
+      Connection:
+      - keep-alive
+      Content-Length:
+      - '592'
+      Content-Type:
+      - application/json
+      Date:
+      - Tue, 27 Sep 2022 22:54:10 GMT
+      X-Request-Time:
+      - 'value: 0.706'
+      x-amz-apigw-id:
+      - ZJDKvFfBCYcFRDg=
+      x-amzn-Remapped-Connection:
+      - keep-alive
+      x-amzn-Remapped-Content-Length:
+      - '592'
+      x-amzn-Remapped-Date:
+      - Tue, 27 Sep 2022 22:54:10 GMT
+      x-amzn-Remapped-Server:
+      - nginx/1.22.0
+      x-amzn-RequestId:
+      - 29809dfb-52f8-4ed9-8acc-c6335348c7db
+    status:
+      code: 200
+      message: OK
+version: 1

tests/resources/test_cards.py

@@ -1,3 +1,5 @@
+import datetime as dt
+
 import pytest
 from cuenca_validations.types import (
     CardFundingType,
@@ -20,6 +22,19 @@ def test_card_create():
     assert len(card.number) == 16
     assert card.type == CardType.virtual
     assert card.user_id == user_id
+    assert card.is_dynamic_cvv is False
+
+
+@pytest.mark.vcr
+def test_card_create_dcvv():
+    card = Card.create(
+        CardIssuer.cuenca, CardFundingType.credit, user_id, is_dynamic_cvv=True
+    )
+    assert card.id
+    assert len(card.number) == 16
+    assert card.type == CardType.virtual
+    assert card.user_id == user_id
+    assert card.is_dynamic_cvv is True
 
 
 @pytest.mark.vcr
@@ -34,10 +49,26 @@ def test_card_retrieve():
     card: Card = Card.retrieve(card_id)
     assert card.id == card_id
     assert len(card.number) == 16
-    assert card.last_4_digits == '9849'
+    assert card.last_4_digits == '7265'
+    assert card.bin == '544875'
+    assert card.type == CardType.virtual
+    assert not card.pin_attempts_exceeded
+    assert card.is_dynamic_cvv is False
+    assert card.dcvv is None
+
+
+@pytest.mark.vcr
+def test_card_retrieve_dcvv():
+    card: Card = Card.retrieve(card_id)
+    assert card.id == card_id
+    assert len(card.number) == 16
+    assert card.last_4_digits == '7265'
     assert card.bin == '544875'
     assert card.type == CardType.virtual
     assert not card.pin_attempts_exceeded
+    assert card.is_dynamic_cvv is True
+    assert card.dcvv.isdigit()
+    assert isinstance(card.dcvv_expires_at, dt.datetime)
 
 
 @pytest.mark.vcr