fix: precompute full_version string to avoid stage2 checkmissingreturns false positive

Author: cs01

scripts/gen-version.js

@@ -14,7 +14,9 @@ try {
 
 const buildDate = new Date().toISOString().slice(0, 10);
 
+const fullVersion = `${pkg.version}-${gitCommit}-${buildDate}`;
+
 writeFileSync(
   "src/version.ts",
-  `export const VERSION = "${pkg.version}";\nexport const GIT_COMMIT = "${gitCommit}";\nexport const BUILD_DATE = "${buildDate}";\n`,
+  `export const VERSION = "${pkg.version}";\nexport const GIT_COMMIT = "${gitCommit}";\nexport const BUILD_DATE = "${buildDate}";\nexport const FULL_VERSION = "${fullVersion}";\n`,
 );

src/chad-native.ts

@@ -60,7 +60,7 @@ declare function cs_watch_loop(
   output_binary: string,
 ): void;
 
-import { VERSION, GIT_COMMIT, BUILD_DATE } from "./version.js";
+import { FULL_VERSION } from "./version.js";
 
 const parser = new ArgumentParser("chad", "compile TypeScript to native binaries via LLVM");
 // Color enabled unless NO_COLOR is set (https://no-color.org/) or TERM=dumb
@@ -119,7 +119,7 @@ parser.addPositional("input", "Input .ts or .js file");
 parser.parse(process.argv);
 
 if (parser.getFlag("version")) {
-  console.log("chad " + VERSION + "-" + GIT_COMMIT + "-" + BUILD_DATE);
+  console.log("chad " + FULL_VERSION);
   process.exit(0);
 }
 

src/chad-node.ts

@@ -31,7 +31,7 @@ import * as path from "path";
 import * as fs from "fs";
 import { execSync, spawn as spawnProc, ChildProcess } from "child_process";
 import { installTargetSDK, listInstalledSDKs, getSDKBaseDir } from "./cross-compile.js";
-import { VERSION, GIT_COMMIT, BUILD_DATE } from "./version.js";
+import { FULL_VERSION } from "./version.js";
 
 const parser = new ArgumentParser("chad", "compile TypeScript to native binaries via LLVM");
 parser.setColorEnabled(process.stdout.isTTY === true);
@@ -104,7 +104,7 @@ parser.addPositional("input", "Input .ts or .js file");
 parser.parse(process.argv.slice(2));
 
 if (parser.getFlag("version")) {
-  console.log(`chad ${VERSION}-${GIT_COMMIT}-${BUILD_DATE}`);
+  console.log(`chad ${FULL_VERSION}`);
   process.exit(0);
 }
 

src/compiler.ts

@@ -11,7 +11,7 @@ import { AST, ImportDeclaration, ClassNode, FunctionNode } from "./ast/types.js"
 import { type LogLevel, LogLevel_Normal, LogLevel_Verbose, logger } from "./utils/logger.js";
 import { TargetInfo, resolveTarget, getHostTarget, isCrossCompiling } from "./target.js";
 import { loadTargetSDK, ensureTargetSDK, TargetSDK } from "./cross-compile.js";
-import { VERSION, GIT_COMMIT, BUILD_DATE } from "./version.js";
+import { FULL_VERSION } from "./version.js";
 import { setGlobalDiagnosticColor } from "./diagnostics/engine.js";
 
 function findLLVMTool(name: string): string {
@@ -192,7 +192,7 @@ export function compile(
   const target = targetOverride || getHostTarget();
   const crossCompiling = isCrossCompiling(target);
 
-  logger.info(`ChadScript compiler version ${VERSION}-${GIT_COMMIT}-${BUILD_DATE}`);
+  logger.info(`ChadScript compiler version ${FULL_VERSION}`);
   logger.info(`Target: ${target.archString}-${target.platformString}`);
   if (crossCompiling) {
     logger.info(`Cross-compiling for ${target.triple}`);