Fix #14697 FN uninitMemberVarNoCtor when mixing (un)initialized member variables

Author: web-flow

lib/checkclass.cpp

@@ -351,16 +351,19 @@ void CheckClass::constructors()
 
             // Variables with default initializers
             bool hasAnyDefaultInit = false;
+            bool hasAnySelfInit = false;
             for (Usage& usage : usageList) {
                 const Variable& var = *usage.var;
 
                 // check for C++11 initializer
                 if (var.hasDefault()) {
                     usage.init = true;
                     hasAnyDefaultInit = true;
+                } else if (!hasAnySelfInit && isInitialized(usage, FunctionType::eConstructor)) {
+                    hasAnySelfInit = true;
                 }
             }
-            if (!hasAnyDefaultInit)
+            if (!hasAnyDefaultInit && !hasAnySelfInit)
                 continue;
 
             handleUnionMembers(usageList);

test/testconstructors.cpp

@@ -769,6 +769,19 @@ class TestConstructors : public TestFixture {
               "    int a, b;\n"
               "};\n");
         ASSERT_EQUALS("", errout_str());
+
+        check("struct S { int i = 0; };\n" // #14697
+              "struct T {\n"
+              "    S s;\n"
+              "    int j;\n"
+              "};\n"
+              "struct U {\n"
+              "    std::string a;\n"
+              "    int k;\n"
+              "};\n");
+        ASSERT_EQUALS("[test.cpp:4:9]: (warning) Member variable 'T::j' has no initializer. [uninitMemberVarNoCtor]\n"
+                      "[test.cpp:8:9]: (warning) Member variable 'U::k' has no initializer. [uninitMemberVarNoCtor]\n",
+                      errout_str());
     }
 
     // ticket #4290 "False Positive: style (noConstructor): The class 'foo' does not have a constructor."