Revert "Extract GiveTime service"

This reverts commit 6c4202b.

Author: sauloperez

app/controllers/users_controller.rb

@@ -62,12 +62,15 @@ def update
   end
 
   def give_time
-    give_time = GiveTime.new(self)
-
-    @user = give_time.user
-    @transfer = give_time.transfer
-    @sources = give_time.sources
-    @offer = give_time.offer
+    @user = scoped_users.find(params[:id])
+    @destination = @user.members.
+                   find_by(organization: current_organization).account.id
+    @source = find_transfer_source
+    @offer = find_transfer_offer
+    @transfer = Transfer.new(source: @source,
+                             destination: @destination,
+                             post: @offer)
+    @sources = find_transfer_sources_for_admin
   end
 
   private
@@ -82,6 +85,22 @@ def user_params
     params.require(:user).permit *fields_to_permit
   end
 
+  def find_transfer_offer
+    current_organization.offers.
+      find(params[:offer]) if params[:offer].present?
+  end
+
+  def find_transfer_source
+    current_user.members.
+      find_by(organization: current_organization).account.id
+  end
+
+  def find_transfer_sources_for_admin
+    return unless admin?
+    [current_organization.account] +
+      current_organization.member_accounts.where("members.active is true")
+  end
+
   def find_user
     if current_user.id == params[:id].to_i
       current_user

app/models/transfer.rb

@@ -19,12 +19,6 @@ class Transfer < ActiveRecord::Base
 
   after_create :make_movements
 
-  # TODO: Extract it along with destination, source and amount accessors. It
-  # absolutely violates encapsulation and adds high coupling.
-  #
-  # EDIT: It might not be that easy. The simple_form_for in give_time.html.erb
-  # depends on this model having the destination column. A form object could be
-  # a solution.
   def make_movements
     movements.create(account: Account.find(source_id), amount: -amount.to_i)
     movements.create(account: Account.find(destination_id), amount: amount.to_i)