Merge pull request RustPython#3738 from gnsxun/notimpl_reduce

Add NotImplemented.__reduce__()

Author: youknowone

Lib/test/test_pickle.py

@@ -128,8 +128,6 @@ def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
     def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_newobj_proxies() # TODO: RUSTPYTHON, remove when this passes
 
-    # TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
-    @unittest.expectedFailure
     def test_notimplemented(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_notimplemented() # TODO: RUSTPYTHON, remove when this passes
 
@@ -163,8 +161,6 @@ def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes
     def test_recursive_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_recursive_nested_names() # TODO: RUSTPYTHON, remove when this passes
 
-    # TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
-    @unittest.expectedFailure
     def test_singleton_types(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_singleton_types() # TODO: RUSTPYTHON, remove when this passes
 
@@ -247,8 +243,6 @@ def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
     def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_newobj_proxies() # TODO: RUSTPYTHON, remove when this passes
 
-    # TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
-    @unittest.expectedFailure
     def test_notimplemented(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_notimplemented() # TODO: RUSTPYTHON, remove when this passes
 
@@ -282,8 +276,6 @@ def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes
     def test_recursive_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_recursive_nested_names() # TODO: RUSTPYTHON, remove when this passes
 
-    # TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
-    @unittest.expectedFailure
     def test_singleton_types(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_singleton_types() # TODO: RUSTPYTHON, remove when this passes
 

Lib/test/test_pickletools.py

@@ -50,8 +50,6 @@ def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
     def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_newobj_proxies()
 
-    # TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
-    @unittest.expectedFailure
     def test_notimplemented(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_notimplemented()
 
@@ -85,8 +83,6 @@ def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes
     def test_recursive_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_recursive_nested_names()
 
-    # TODO: RUSTPYTHON, TypeError: cannot pickle 'NotImplementedType' object
-    @unittest.expectedFailure
     def test_singleton_types(self): # TODO: RUSTPYTHON, remove when this passes
         super().test_singleton_types()
 

vm/src/builtins/singletons.rs

@@ -84,6 +84,11 @@ impl PyNotImplemented {
     fn repr(&self) -> String {
         "NotImplemented".to_owned()
     }
+
+    #[pymethod(magic)]
+    fn reduce(&self) -> String {
+        "NotImplemented".to_owned()
+    }
 }
 
 pub fn init(context: &Context) {