Merge pull request RustPython#3932 from jopemachine/edit-float-getformat

youknowone · web-flow · commit db6fd1692015 · 2022-07-19T20:33:45.000+09:00
Fix `float.__getformat__`
diff --git a/vm/src/builtins/float.rs b/vm/src/builtins/float.rs
@@ -204,8 +204,8 @@ impl PyFloat {
         }
     }
 
-    #[pymethod(magic)]
-    fn getformat(&self, spec: PyStrRef, vm: &VirtualMachine) -> PyResult<String> {
+    #[pystaticmethod(magic)]
+    fn getformat(spec: PyStrRef, vm: &VirtualMachine) -> PyResult<String> {
         if !matches!(spec.as_str(), "double" | "float") {
             return Err(vm.new_value_error(
                 "__getformat__() argument 1 must be 'double' or 'float'".to_owned(),

Original file line number	Diff line number	Diff line change
`@@ -204,8 +204,8 @@ impl PyFloat {`
`204`	`204`	`}`
`205`	`205`	`}`
`206`	`206`
`207`		`- #[pymethod(magic)]`
`208`		`- fn getformat(&self, spec: PyStrRef, vm: &VirtualMachine) -> PyResult<String> {`
	`207`	`+ #[pystaticmethod(magic)]`
	`208`	`+ fn getformat(spec: PyStrRef, vm: &VirtualMachine) -> PyResult<String> {`
`209`	`209`	`if !matches!(spec.as_str(), "double" \| "float") {`
`210`	`210`	`return Err(vm.new_value_error(`
`211`	`211`	`"__getformat__() argument 1 must be 'double' or 'float'".to_owned(),`