Merge pull request RustPython#3914 from oow214/mappingproxy

Add mappingproxy richcompare

Author: youknowone

Lib/test/test_types.py

@@ -982,8 +982,6 @@ def test_or_type_operator_reference_cycle(self):
 class MappingProxyTests(unittest.TestCase):
     mappingproxy = types.MappingProxyType
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_constructor(self):
         class userdict(dict):
             pass

vm/src/builtins/mappingproxy.rs

@@ -2,9 +2,9 @@ use super::{PyDict, PyDictRef, PyGenericAlias, PyList, PyTuple, PyType, PyTypeRe
 use crate::{
     class::PyClassImpl,
     convert::ToPyObject,
-    function::{ArgMapping, OptionalArg},
+    function::{ArgMapping, OptionalArg, PyComparisonValue},
     protocol::{PyMapping, PyMappingMethods, PyNumberMethods, PySequence, PySequenceMethods},
-    types::{AsMapping, AsNumber, AsSequence, Constructor, Iterable},
+    types::{AsMapping, AsNumber, AsSequence, Comparable, Constructor, Iterable, PyComparisonOp},
     AsObject, Context, Py, PyObject, PyObjectRef, PyPayload, PyRef, PyResult, VirtualMachine,
 };
 
@@ -64,7 +64,7 @@ impl Constructor for PyMappingProxy {
     }
 }
 
-#[pyimpl(with(AsMapping, Iterable, Constructor, AsSequence))]
+#[pyimpl(with(AsMapping, Iterable, Constructor, AsSequence, Comparable))]
 impl PyMappingProxy {
     fn get_inner(&self, key: PyObjectRef, vm: &VirtualMachine) -> PyResult<Option<PyObjectRef>> {
         let opt = match &self.mapping {
@@ -185,6 +185,20 @@ impl PyMappingProxy {
     }
 }
 
+impl Comparable for PyMappingProxy {
+    fn cmp(
+        zelf: &crate::Py<Self>,
+        other: &PyObject,
+        op: PyComparisonOp,
+        vm: &VirtualMachine,
+    ) -> PyResult<PyComparisonValue> {
+        let obj = zelf.to_object(vm)?;
+        Ok(PyComparisonValue::Implemented(
+            obj.rich_compare_bool(other, op, vm)?,
+        ))
+    }
+}
+
 impl AsMapping for PyMappingProxy {
     const AS_MAPPING: PyMappingMethods = PyMappingMethods {
         length: Some(|mapping, vm| Self::mapping_downcast(mapping).len(vm)),