Skip to content

Commit 48cf792

Browse files
authored
Merge pull request RustPython#3888 from fanninpm/dtolnay-is-awesome
Abandon `actions-rs` actions
2 parents ddc801e + 86f7e07 commit 48cf792

File tree

2 files changed

+35
-92
lines changed

2 files changed

+35
-92
lines changed

.github/workflows/ci.yaml

Lines changed: 28 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ concurrency:
1414

1515
env:
1616
CARGO_ARGS: --features ssl,jit
17-
NON_WASM_PACKAGES: >
17+
NON_WASM_PACKAGES: >-
1818
-p rustpython-bytecode
1919
-p rustpython-common
2020
-p rustpython-compiler
@@ -52,7 +52,7 @@ jobs:
5252
fail-fast: false
5353
steps:
5454
- uses: actions/checkout@v2
55-
- uses: actions-rs/toolchain@v1
55+
- uses: dtolnay/rust-toolchain@stable
5656
- name: Set up the Windows environment
5757
shell: bash
5858
run: |
@@ -64,26 +64,17 @@ jobs:
6464
if: runner.os == 'macOS'
6565
- uses: Swatinem/rust-cache@v1
6666
- name: run rust tests
67-
uses: actions-rs/cargo@v1
68-
with:
69-
command: test
70-
args: --workspace --exclude rustpython_wasm --verbose ${{ env.CARGO_ARGS }} ${{ env.NON_WASM_PACKAGES }}
67+
run: cargo test --workspace --exclude rustpython_wasm --verbose ${{ env.CARGO_ARGS }} ${{ env.NON_WASM_PACKAGES }}
7168
- name: check compilation without threading
72-
uses: actions-rs/cargo@v1
73-
with:
74-
command: check
75-
args: ${{ env.CARGO_ARGS }} --no-default-features
69+
run: cargo check ${{ env.CARGO_ARGS }} --no-default-features
7670

7771
- name: prepare AppleSilicon build
78-
uses: actions-rs/toolchain@v1
72+
uses: dtolnay/rust-toolchain@stable
7973
with:
8074
target: aarch64-apple-darwin
8175
if: runner.os == 'macOS'
8276
- name: Check compilation for Apple Silicon
83-
uses: actions-rs/cargo@v1
84-
with:
85-
command: check
86-
args: --target aarch64-apple-darwin
77+
run: cargo check --target aarch64-apple-darwin
8778
if: runner.os == 'macOS'
8879

8980
exotic_targets:
@@ -92,67 +83,49 @@ jobs:
9283
steps:
9384
- uses: actions/checkout@v2
9485

95-
- uses: actions-rs/toolchain@v1
86+
- uses: dtolnay/rust-toolchain@stable
9687
with:
9788
target: i686-unknown-linux-gnu
9889

9990
- name: Install gcc-multilib and musl-tools
10091
run: sudo apt-get update && sudo apt-get install gcc-multilib musl-tools
10192
- name: Check compilation for x86 32bit
102-
uses: actions-rs/cargo@v1
103-
with:
104-
command: check
105-
args: --target i686-unknown-linux-gnu
93+
run: cargo check --target i686-unknown-linux-gnu
10694

107-
- uses: actions-rs/toolchain@v1
95+
- uses: dtolnay/rust-toolchain@stable
10896
with:
10997
target: aarch64-linux-android
11098

11199
- name: Check compilation for android
112-
uses: actions-rs/cargo@v1
113-
with:
114-
command: check
115-
args: --target aarch64-linux-android
100+
run: cargo check --target aarch64-linux-android
116101

117-
- uses: actions-rs/toolchain@v1
102+
- uses: dtolnay/rust-toolchain@stable
118103
with:
119104
target: i686-unknown-linux-musl
120105

121106
- name: Check compilation for musl
122-
uses: actions-rs/cargo@v1
123-
with:
124-
command: check
125-
args: --target i686-unknown-linux-musl
107+
run: cargo check --target i686-unknown-linux-musl
126108

127-
- uses: actions-rs/toolchain@v1
109+
- uses: dtolnay/rust-toolchain@stable
128110
with:
129111
target: x86_64-unknown-freebsd
130112

131113
- name: Check compilation for freebsd
132-
uses: actions-rs/cargo@v1
133-
with:
134-
command: check
135-
args: --target x86_64-unknown-freebsd
114+
run: cargo check --target x86_64-unknown-freebsd
136115

137-
- uses: actions-rs/toolchain@v1
116+
- uses: dtolnay/rust-toolchain@stable
138117
with:
139118
target: wasm32-unknown-unknown
140119

141120
- name: Check compilation for wasm32
142-
uses: actions-rs/cargo@v1
143-
with:
144-
command: check
145-
args: --target wasm32-unknown-unknown --no-default-features
121+
run: cargo check --target wasm32-unknown-unknown --no-default-features
146122

147-
- uses: actions-rs/toolchain@v1
123+
- uses: dtolnay/rust-toolchain@stable
148124
with:
149125
target: x86_64-unknown-freebsd
150126

151127
- name: Check compilation for freeBSD
152-
uses: actions-rs/cargo@v1
153-
with:
154-
command: check
155-
args: --target x86_64-unknown-freebsd
128+
run: cargo check --target x86_64-unknown-freebsd
156129

157130
- name: Prepare repository for redox compilation
158131
run: bash scripts/redox/uncomment-cargo.sh
@@ -173,7 +146,7 @@ jobs:
173146
fail-fast: false
174147
steps:
175148
- uses: actions/checkout@v2
176-
- uses: actions-rs/toolchain@v1
149+
- uses: dtolnay/rust-toolchain@stable
177150
- uses: actions/setup-python@v2
178151
with:
179152
python-version: "3.10"
@@ -188,10 +161,7 @@ jobs:
188161
if: runner.os == 'macOS'
189162
- uses: Swatinem/rust-cache@v1
190163
- name: build rustpython
191-
uses: actions-rs/cargo@v1
192-
with:
193-
command: build
194-
args: --release --verbose ${{ env.CARGO_ARGS }}
164+
run: cargo build --release --verbose ${{ env.CARGO_ARGS }}
195165
- uses: actions/setup-python@v2
196166
with:
197167
python-version: "3.10"
@@ -244,26 +214,15 @@ jobs:
244214
runs-on: ubuntu-latest
245215
steps:
246216
- uses: actions/checkout@v2
247-
- uses: actions-rs/toolchain@v1
217+
- uses: dtolnay/rust-toolchain@stable
248218
with:
249-
profile: minimal
250219
components: rustfmt, clippy
251-
override: true
252220
- name: run rustfmt
253-
uses: actions-rs/cargo@v1
254-
with:
255-
command: fmt
256-
args: --all -- --check
221+
run: cargo fmt --all -- --check
257222
- name: run clippy
258-
uses: actions-rs/cargo@v1
259-
with:
260-
command: clippy
261-
args: ${{ env.CARGO_ARGS }} ${{ env.NON_WASM_PACKAGES }} -- -Dwarnings
223+
run: cargo clippy ${{ env.CARGO_ARGS }} ${{ env.NON_WASM_PACKAGES }} -- -Dwarnings
262224
- name: run clippy on wasm
263-
uses: actions-rs/cargo@v1
264-
with:
265-
command: clippy
266-
args: --manifest-path=wasm/lib/Cargo.toml -- -Dwarnings
225+
run: cargo clippy --manifest-path=wasm/lib/Cargo.toml -- -Dwarnings
267226
- uses: actions/setup-python@v2
268227
with:
269228
python-version: "3.10"
@@ -281,12 +240,10 @@ jobs:
281240
runs-on: ubuntu-latest
282241
steps:
283242
- uses: actions/checkout@v2
284-
- uses: actions-rs/toolchain@v1
243+
- uses: dtolnay/rust-toolchain@master
285244
with:
286-
profile: minimal
287245
toolchain: nightly
288246
components: miri
289-
override: true
290247
- uses: Swatinem/rust-cache@v1
291248
- name: Run tests under miri
292249
# miri-ignore-leaks because the type-object circular reference means that there will always be
@@ -299,7 +256,7 @@ jobs:
299256
runs-on: ubuntu-latest
300257
steps:
301258
- uses: actions/checkout@v2
302-
- uses: actions-rs/toolchain@v1
259+
- uses: dtolnay/rust-toolchain@stable
303260
- name: Cache cargo dependencies
304261
uses: actions/cache@v2
305262
with:
@@ -355,11 +312,9 @@ jobs:
355312
runs-on: ubuntu-latest
356313
steps:
357314
- uses: actions/checkout@v2
358-
- uses: actions-rs/toolchain@v1
315+
- uses: dtolnay/rust-toolchain@stable
359316
with:
360-
toolchain: stable
361317
target: wasm32-wasi
362-
override: true
363318
- name: Setup Wasmer
364319
uses: wasmerio/setup-wasmer@v1
365320
- name: Install clang
@@ -375,9 +330,6 @@ jobs:
375330
restore-keys: |
376331
${{ runner.os }}-debug_opt3-${{ hashFiles('**/Cargo.lock') }}
377332
- name: build rustpython
378-
uses: actions-rs/cargo@v1
379-
with:
380-
command: build
381-
args: --release --target wasm32-wasi --features freeze-stdlib,stdlib --verbose
333+
run: cargo build --release --target wasm32-wasi --features freeze-stdlib,stdlib --verbose
382334
- name: run snippets
383335
run: wasmer run --dir . target/wasm32-wasi/release/rustpython.wasm -- extra_tests/snippets/stdlib_random.py

.github/workflows/cron-ci.yaml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,11 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v2
17-
- uses: actions-rs/toolchain@v1
17+
- uses: dtolnay/rust-toolchain@stable
1818
with:
1919
components: llvm-tools-preview
2020
- run: sudo apt-get update && sudo apt-get -y install lcov
21-
- uses: actions-rs/cargo@v1
22-
with:
23-
command: build
24-
args: --release --verbose ${{ env.CARGO_ARGS }}
21+
- run: cargo build --release --verbose ${{ env.CARGO_ARGS }}
2522
env:
2623
RUSTC_WRAPPER: './scripts/codecoverage-rustc-wrapper.sh'
2724
- uses: actions/setup-python@v2
@@ -58,12 +55,9 @@ jobs:
5855
runs-on: ubuntu-latest
5956
steps:
6057
- uses: actions/checkout@v2
61-
- uses: actions-rs/toolchain@v1
58+
- uses: dtolnay/rust-toolchain@stable
6259
- name: build rustpython
63-
uses: actions-rs/cargo@v1
64-
with:
65-
command: build
66-
args: --release --verbose
60+
run: cargo build --release --verbose
6761
- name: collect tests data
6862
run: cargo run --release extra_tests/jsontests.py
6963
env:
@@ -89,12 +83,9 @@ jobs:
8983
runs-on: ubuntu-latest
9084
steps:
9185
- uses: actions/checkout@v2
92-
- uses: actions-rs/toolchain@v1
86+
- uses: dtolnay/rust-toolchain@stable
9387
- name: build rustpython
94-
uses: actions-rs/cargo@v1
95-
with:
96-
command: build
97-
args: --release --verbose
88+
run: cargo build --release --verbose
9889
- name: Collect what is left data
9990
run: |
10091
chmod +x ./whats_left.sh
@@ -123,7 +114,7 @@ jobs:
123114
runs-on: ubuntu-latest
124115
steps:
125116
- uses: actions/checkout@v2
126-
- uses: actions-rs/toolchain@v1
117+
- uses: dtolnay/rust-toolchain@stable
127118
- uses: actions/setup-python@v2
128119
with:
129120
python-version: 3.9

0 commit comments

Comments
 (0)